Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp7280911imm; Thu, 28 Jun 2018 00:42:42 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKdTewDwWbGgSXFoU5ma8t3cCvg5HCoPMhJVYLECDWaVsa1AIlKhCSqqUQsLpHExO+EaFmV X-Received: by 2002:a17:902:5a0c:: with SMTP id q12-v6mr9295205pli.300.1530171762365; Thu, 28 Jun 2018 00:42:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530171762; cv=none; d=google.com; s=arc-20160816; b=jFfwUQ/IZ9+YwMIii/x8fFFqB4TztN1j01Cjqdk0lfphdcqaDwRWS6rD+XQ2SG1bUC aBNfvi9u0Wi4sjZcYmbtLm1ML9LI+CSdhjb9jJCkGCjGSRbAGbcwy3IhFuNtHIw4c74E FI+TOkLiOsYF7knHQU50AAw8/R2VGUAnsTOM3wxaclQERcv48pkVjL6jV/Eehybw5f3K jA0QUD9+KJD+QWNJoGKm4JwK9LOEpfXfnn/PHpS2iphi1FI9/G8LdYnhubIJVGEOzd/x Bj9Ih2JUu6GiLO/0pLrQOA34Md8OyjhhhKHxYiiAYjCC5t0lRgidI9Z6G7/ySOGcECnz B3Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:references:in-reply-to:mime-version :dkim-signature:arc-authentication-results; bh=9BbF816HJ2FDNCrFiTMVnOCqXkLcvBIl9cfjSRowKAw=; b=eQE/7GwTefwlGVUZDdXSsXwckhbhgFrp7uKwRJ8XmPLmLIuSRAVNZNBNC1LSlCxflN XfFTbuK5H84beP7o+u1P+n6oVHz/4/ixR9DkiXtuXuYVMNgsfu5Lg1pEoXvkGWORCC+V PU+Ry1OyeACUQZX18mP2fn2VxWvXK3LZhAr17XkvaGNoNTCaiOmdITxOri9GAQHstJfJ +guEceD+9nwQ76SRInWEfW9aeflyHScit+LebvL8mcA/Xgyr1mdDBK0kOik9CC0/q1ZR /rPEH6usQHq/eA9Lgr61vQo7v+3CHYXig+msQFeQne6L25t37XZTX5P65xzF95gR8Ec7 3apQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kZG4uJee; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc12-v6si5774501plb.373.2018.06.28.00.42.27; Thu, 28 Jun 2018 00:42:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kZG4uJee; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965153AbeF1Hla (ORCPT + 99 others); Thu, 28 Jun 2018 03:41:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:34308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934309AbeF1HlZ (ORCPT ); Thu, 28 Jun 2018 03:41:25 -0400 Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B28F2705A; Thu, 28 Jun 2018 07:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1530171684; bh=2NgZZIPYg80uFUlXdXNisbCUMeL8Jiq9sAEIxMtXB3M=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=kZG4uJeeKtZCak1qf/S3UqURmVLitv0JS48kQQdyysILS4d0v1Km8YwKXVV5CPKSo Ls96IBoYc4kyO6GdoeZLCuiOEe1SMnFOj9u12ziUSv+9E5KJrKbGkqqZHTKV4uZumn Rx6FCIrDGJ/QlolGWYd5TIJmEJYHjJDZKj32WhA0= Received: by mail-wr0-f171.google.com with SMTP id c13-v6so4415855wrq.2; Thu, 28 Jun 2018 00:41:24 -0700 (PDT) X-Gm-Message-State: APt69E0ELeJg47f82PfdMY8ixz7hKDXO65nz2bOEn30/HMfKfu/H9xRT CyPBXyEAonAotiBovSyHCiYKhG76RpDNnt9EnVQ= X-Received: by 2002:adf:9883:: with SMTP id w3-v6mr8209922wrb.9.1530171682519; Thu, 28 Jun 2018 00:41:22 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:9166:0:0:0:0:0 with HTTP; Thu, 28 Jun 2018 00:41:21 -0700 (PDT) In-Reply-To: <1530119544-30023-3-git-send-email-pawel.mikolaj.chmiel@gmail.com> References: <1530119544-30023-1-git-send-email-pawel.mikolaj.chmiel@gmail.com> <1530119544-30023-3-git-send-email-pawel.mikolaj.chmiel@gmail.com> From: Krzysztof Kozlowski Date: Thu, 28 Jun 2018 09:41:21 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 02/10] ARM: dts: s5pv210: Add initial DTS for Samsung Aries based phones To: =?UTF-8?Q?Pawe=C5=82_Chmiel?= Cc: kgene@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, xc-racer2@live.ca Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27 June 2018 at 19:12, Pawe=C5=82 Chmiel wrote: > This DTS file have initial support Samsung Aries based phones. > Initial version have support for: > - sdcard > - internal memory (present only on non 4g variant) > - max8998 pmic and rtc > - max17040 fuel gauge > - gpio keys > - fimd (no panel driver yet) > - usb (peripherial mode) > - wifi > > Signed-off-by: Pawe=C5=82 Chmiel > --- > > Changes from v1: > - Removed duplicated and unneeded headers > - Corrected node names > - Added missing spaces > - Removed unneeded pinctrl and sorted entries > - Set correct interrupt type for max8998 pmic > - Add missing regulators > --- > --- > arch/arm/boot/dts/s5pv210-aries.dtsi | 423 +++++++++++++++++++++++++++++= ++++++ > 1 file changed, 423 insertions(+) > create mode 100644 arch/arm/boot/dts/s5pv210-aries.dtsi > > diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5p= v210-aries.dtsi > new file mode 100644 > index 000000000000..61b6cf76265f > --- /dev/null > +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi > @@ -0,0 +1,423 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung's S5PV210 based Galaxy Aries board device tree source > + */ > + > +/dts-v1/; > +#include > +#include > +#include "s5pv210.dtsi" > + > +/ { > + compatible =3D "samsung,aries", "samsung,s5pv210"; > + > + aliases { > + i2c6 =3D &i2c_pmic; > + i2c9 =3D &i2c_fuel; > + }; > + > + memory@30000000 { > + device_type =3D "memory"; > + reg =3D <0x30000000 0x05000000 > + 0x40000000 0x10000000 > + 0x50000000 0x08000000>; > + }; > + > + wifi_pwrseq: wifi-pwrseq { > + compatible =3D "mmc-pwrseq-simple"; > + reset-gpios =3D <&gpg1 2 GPIO_ACTIVE_LOW>; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&wlan_gpio_rst>; > + post-power-on-delay-ms =3D <500>; > + power-off-delay-us =3D <500>; > + }; > + > + i2c_pmic: i2c-gpio-0 { > + compatible =3D "i2c-gpio"; > + sda-gpios =3D <&gpj4 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAI= N)>; > + scl-gpios =3D <&gpj4 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAI= N)>; > + i2c-gpio,delay-us =3D <2>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + pmic@66 { > + compatible =3D "maxim,max8998"; > + reg =3D <0x66>; > + interrupt-parent =3D <&gph0>; > + interrupts =3D <7 IRQ_TYPE_EDGE_FALLING>; > + > + max8998,pmic-buck1-default-dvs-idx =3D <1>; > + max8998,pmic-buck1-dvs-gpios =3D <&gph0 3 GPIO_AC= TIVE_HIGH>, > + <&gph0 4 GPIO_ACT= IVE_HIGH>; > + max8998,pmic-buck1-dvs-voltage =3D <1275000>, <12= 00000>, > + <1050000>, <95000= 0>; > + > + max8998,pmic-buck2-default-dvs-idx =3D <0>; > + max8998,pmic-buck2-dvs-gpio =3D <&gph0 5 GPIO_ACT= IVE_HIGH>; > + max8998,pmic-buck2-dvs-voltage =3D <1100000>, <10= 00000>; > + > + regulators { > + ldo2_reg: LDO2 { > + regulator-name =3D "VALIVE_1.2V"; > + regulator-min-microvolt =3D <1200= 000>; > + regulator-max-microvolt =3D <1200= 000>; > + regulator-always-on; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + }; > + }; > + > + ldo3_reg: LDO3 { > + regulator-name =3D "VUSB_1.1V"; > + regulator-min-microvolt =3D <1100= 000>; > + regulator-max-microvolt =3D <1100= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo4_reg: LDO4 { > + regulator-name =3D "VADC_3.3V"; > + regulator-min-microvolt =3D <3300= 000>; > + regulator-max-microvolt =3D <3300= 000>; > + regulator-always-on; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo5_reg: LDO5 { > + regulator-name =3D "VTF_2.8V"; > + regulator-min-microvolt =3D <2800= 000>; > + regulator-max-microvolt =3D <2800= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo6_reg: LDO6 { > + regulator-name =3D "LDO6"; > + regulator-min-microvolt =3D <1600= 000>; > + regulator-max-microvolt =3D <3600= 000>; > + }; > + > + ldo7_reg: LDO7 { > + regulator-name =3D "VLCD_1.8V"; > + regulator-min-microvolt =3D <1800= 000>; > + regulator-max-microvolt =3D <1800= 000>; > + /* Till we get panel driver */ > + regulator-always-on; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo8_reg: LDO8 { > + regulator-name =3D "VUSB_3.3V"; > + regulator-min-microvolt =3D <3300= 000>; > + regulator-max-microvolt =3D <3300= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo9_reg: LDO9 { > + regulator-name =3D "VCC_2.8V_PDA"= ; > + regulator-min-microvolt =3D <2800= 000>; > + regulator-max-microvolt =3D <2800= 000>; > + regulator-always-on; > + }; > + > + ldo10_reg: LDO10 { > + regulator-name =3D "VPLL_1.2V"; > + regulator-min-microvolt =3D <1200= 000>; > + regulator-max-microvolt =3D <1200= 000>; > + regulator-always-on; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + }; > + }; > + > + ldo11_reg: LDO11 { > + regulator-name =3D "CAM_AF_3.0V"; > + regulator-min-microvolt =3D <3000= 000>; > + regulator-max-microvolt =3D <3000= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo12_reg: LDO12 { > + regulator-name =3D "CAM_SENSOR_CO= RE_1.2V"; > + regulator-min-microvolt =3D <1200= 000>; > + regulator-max-microvolt =3D <1200= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo13_reg: LDO13 { > + regulator-name =3D "VGA_VDDIO_2.8= V"; > + regulator-min-microvolt =3D <2800= 000>; > + regulator-max-microvolt =3D <2800= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo14_reg: LDO14 { > + regulator-name =3D "VGA_DVDD_1.8V= "; > + regulator-min-microvolt =3D <1800= 000>; > + regulator-max-microvolt =3D <1800= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo15_reg: LDO15 { > + regulator-name =3D "CAM_ISP_HOST_= 2.8V"; > + regulator-min-microvolt =3D <2800= 000>; > + regulator-max-microvolt =3D <2800= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo16_reg: LDO16 { > + regulator-name =3D "VGA_AVDD_2.8V= "; > + regulator-min-microvolt =3D <2800= 000>; > + regulator-max-microvolt =3D <2800= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ldo17_reg: LDO17 { > + regulator-name =3D "VCC_3.0V_LCD"= ; > + regulator-min-microvolt =3D <3000= 000>; > + regulator-max-microvolt =3D <3000= 000>; > + /* Till we get panel driver */ > + regulator-always-on; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + buck1_reg: BUCK1 { > + regulator-name =3D "vddarm"; > + regulator-min-microvolt =3D <7500= 00>; > + regulator-max-microvolt =3D <1500= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-suspend-microvo= lt =3D <1250000>; > + }; > + }; > + > + buck2_reg: BUCK2 { > + regulator-name =3D "vddint"; > + regulator-min-microvolt =3D <7500= 00>; > + regulator-max-microvolt =3D <1500= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + regulator-suspend-microvo= lt =3D <1100000>; > + }; > + }; > + > + buck3_reg: BUCK3 { > + regulator-name =3D "VCC_1.8V"; > + regulator-min-microvolt =3D <1800= 000>; > + regulator-max-microvolt =3D <1800= 000>; > + regulator-always-on; > + }; > + > + buck4_reg: BUCK4 { > + regulator-name =3D "CAM_ISP_CORE_= 1.2V"; > + regulator-min-microvolt =3D <1200= 000>; > + regulator-max-microvolt =3D <1200= 000>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + ap32khz_reg: EN32KHz-AP { > + regulator-name =3D "32KHz AP"; > + regulator-always-on; > + }; > + > + cp32khz_reg: EN32KHz-CP { > + regulator-name =3D "32KHz CP"; > + }; > + > + vichg_reg: ENVICHG { > + regulator-name =3D "VICHG"; > + regulator-always-on; > + }; > + > + safe1_sreg: ESAFEOUT1 { > + regulator-name =3D "SAFEOUT1"; > + }; > + > + safe2_sreg: ESAFEOUT2 { > + regulator-name =3D "SAFEOUT2"; > + }; > + }; > + }; > + }; > + > + i2c_fuel: i2c-gpio-1 { > + compatible =3D "i2c-gpio"; > + sda-gpios =3D <&mp05 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAI= N)>; > + scl-gpios =3D <&mp05 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAI= N)>; > + i2c-gpio,delay-us =3D <2>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + fuelgauge@36 { > + compatible =3D "maxim,max17040"; > + interrupt-parent =3D <&vic0>; > + interrupts =3D <7>; > + reg =3D <0x36>; > + }; > + }; > +}; > + > +&xusbxti { > + clock-frequency =3D <24000000>; > +}; > + > +&pinctrl0 { Thanks for changes. You missed one part - ordering the labels here alphabetically, so: &fimd {} &hsotg {} ... &xusbxti {} Best regards, Krzysztof