Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp7282537imm; Thu, 28 Jun 2018 00:44:57 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJhLIMW1jCoFF0Xd5iOkii1WPmkfRhmLevumKw50mIE5jYfvflxOiHWe8QPhZ6ueLNLo8um X-Received: by 2002:a63:7454:: with SMTP id e20-v6mr8138060pgn.410.1530171897865; Thu, 28 Jun 2018 00:44:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530171897; cv=none; d=google.com; s=arc-20160816; b=vqe1j4lbpJ4uYZUbGaSrBnDA6yGEWxjIJsycxHHepuQAT1uDyPTFaEnFXwA79gcoxN XcQoRZ5V9AWQliO8nxehri2bP5mw1ThTDAEB6hUnWmDw+zHn2WFlUAgP2NhtDMFHDG8V ch5oTU44C89BHkcd+oysNB4KY9AS4yi1ISrYag3SmaHVjE9AdQ/a6VC7MU3M1cqmHX0r poFiRJ79HgLGbDRtxH66o4e8Y3MUuQyKXN/cAx8Haekh+eUERo03tDNycWdtIxdynaQP I9Dy9r++FuCvbrPgLgVKAOaCB+c4FMXKZhKWJDyWLRhiy6EJtdvd0ksEoiSstexz0QjM FR6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=bSjOueripNnsfJcnpIcMV9YUXy6UELbY+jjx55EWVnU=; b=FZVz22tVingygyPGNS1n/9mBXPg63vmEbmw5gsNgvE/yqnn26MsobiS5NNlsPNCMoM XOxEffh8txuMpETsrkR8QlMFy7JU2iPWc6OX+DyqxOZ7BEW2g5toyZLbeSO0X+Jk9Lag J+PJ2GZlPhm0ds+oBuhEM8AYyc4onuWOvSe9vrCR9vtdfMSgsSZGtMgVDKAYFH7BNK1R qAOdzpfglpgOLUTfHo4bHuMqqPU+MmMYeLGilrwkSR+Iv4PtFBKBu/v+f3zJGYa4yiVG 0QkX8hpMX0cDTfUuQ20/blcP6KwbiodtutdIqgqZVBDRz2mcx0km6d7tEYi97zl5zeip plVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ch+bRXgT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6-v6si5612532pgu.45.2018.06.28.00.44.43; Thu, 28 Jun 2018 00:44:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ch+bRXgT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965216AbeF1Hno (ORCPT + 99 others); Thu, 28 Jun 2018 03:43:44 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:40002 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964955AbeF1Hnn (ORCPT ); Thu, 28 Jun 2018 03:43:43 -0400 Received: by mail-io0-f196.google.com with SMTP id t135-v6so4320302iof.7 for ; Thu, 28 Jun 2018 00:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bSjOueripNnsfJcnpIcMV9YUXy6UELbY+jjx55EWVnU=; b=ch+bRXgTfbyQd5VMVCyn3mEQ6QFibvGZMkpdiCaUG8/oiqZFmzPYy9GY63l84OeoQK +xrgGMR9P+LA3tuHOQf+UrmwUlH4yn1u542Nr7HKBd3QUd+GyxabXw49Uch/+fQD62Z9 BHULJLi2BuvGH1vrF3qKWxfVr4p31SHiA5D/4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bSjOueripNnsfJcnpIcMV9YUXy6UELbY+jjx55EWVnU=; b=CRXKHf7/UVcYpWrBur1e/c6/cF19zA4RvlRwM8D+sTxsjy1tFih1bE3Iq3X8U6QG8k ZozU/MrFvAZbrwku5gDV+YUj0Nfk/PEpksS7tur4y8zg+SCevyA4aKP9J/ZPS2hpyBoA jkyWGgjYMPHDiHuE4D+7aEwm5yyCTkhsaLiR/nXljmQPXXTwHyUJBg1324qmnfXlfTsI P1z/slrrYo660VWeba80CmdZs1+g3fU9TMxb5vcdjwkvOvBcPBCvxJKOM9gDjaxcDxF/ NpoiTMych9RyhJUYzAt5vloJe2OVxoM3V8U08WP40c+nMYWTF56/KJb4rKaC6SZBBi4y QrDw== X-Gm-Message-State: APt69E1vtS/+D9CaM9wyxWaG9gbacw+PXO+HwNBasgupuOKPDKS8kjLW F9OryCk5EDAhfIo10xZW5v90jdLn/Fu/BAd3+zAPtQ== X-Received: by 2002:a6b:6c0b:: with SMTP id a11-v6mr7567265ioh.175.1530171822851; Thu, 28 Jun 2018 00:43:42 -0700 (PDT) MIME-Version: 1.0 References: <1529563351-2241-1-git-send-email-naga.sureshkumar.relli@xilinx.com> <1529563351-2241-5-git-send-email-naga.sureshkumar.relli@xilinx.com> In-Reply-To: <1529563351-2241-5-git-send-email-naga.sureshkumar.relli@xilinx.com> From: Linus Walleij Date: Thu, 28 Jun 2018 09:43:30 +0200 Message-ID: Subject: Re: [[LINUX PATCH v10] 4/4] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface To: naga.sureshkumar.relli@xilinx.com Cc: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Mark Vasut , Florian Fainelli , Markus Mayer , Roger Quadros , Ladislav Michl , ada@thorsis.com, honghui.zhang@mediatek.com, =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , linux-mtd@lists.infradead.org, "linux-kernel@vger.kernel.org" , nagasureshkumarrelli@gmail.com, michals@xilinx.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 21, 2018 at 8:43 AM Naga Sureshkumar Relli wrote: Thank you for your patch! > Add driver for arm pl353 static memory controller nand interface with HW ECC > support. This controller is used in Xilinx Zynq SoC for interfacing the NAND > flash memory. > > Signed-off-by: Naga Sureshkumar Relli This driver has the same problem as the other patches: use the ARM_AMBA primecell magic numbers detection, and the PrimeCell bus. Otherwise it looks good to me! Yours, Linus Walleij