Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp7394469imm; Thu, 28 Jun 2018 03:05:29 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcVp28OcW2k2Rc5BIvoV/PZkh5H+2NGQltt4qnhTTy+25eEsGIzaX4H58W/fHnpZKj7IihL X-Received: by 2002:a62:e816:: with SMTP id c22-v6mr9458201pfi.124.1530180329459; Thu, 28 Jun 2018 03:05:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530180329; cv=none; d=google.com; s=arc-20160816; b=F8buqkiiJES98Q5HHPWIsaUl8nJHfHLrMhhE4yY93nrLyHMEfDMNqTxnkeONaMlUlS OspCeTEfTmSQkse4/RDyaIl9a+Wz3uBU43rjkpYndelzRSpPiaGUQ9CuZi8y9XoglVME DkbOCCOBvRV3wjKqyvQv7dE6r27NKYjWPGd3OidunUBAoHtnyaT3L9gOq/2FdGnl4LWw 7re7yDwAU/sy37eN7ciDw1294xBafdBOKXvI6tImtvNEC7L7k2cdezQiYP5LJtCiWH9U VKezTozJYeFQqYyPq1fc8+pStjAEvahGMRmEooJhbp4scCEL4WipSOJ47J9e9ys/2H/z CfuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=EUHUXhhEy2o4J5rrnu5f10WOpSCVshkBgwpdYeho8qw=; b=MLyuY1CaP4ZcRke6cIR4CfnfXDsqyp5Fx/eQBu0J3IF6QLUKO3yMROTLpT65oDr1Mz eEpfmVIJ21jQSgkBDL1FTfmJeOw+l7+wcR/foNJXB6ow+3duIiGLJC7T+B62Fa/+9Q2O cs3gChNT/NjaKw8pPNrJa9/H5BPdzINJe0c2pITaOJ0DTmg1jTnfPAxQ4n5FCXEFySXN v9djxWsLm0hkvXLSC1giZS8tLo/ybITBKSJW8qCqJSRQHuLEuIkyHOxDVRdvt0kdsspo Mrap59fM6+R1Qh7bTyHf1xXEMxZBii1qaiXEBib0qnBegoHQu5LhHz5ynEwBDBvS6N/i 4ApQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@agner.ch header.s=dkim header.b=G+S5nWa7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7-v6si6602446plz.510.2018.06.28.03.05.12; Thu, 28 Jun 2018 03:05:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@agner.ch header.s=dkim header.b=G+S5nWa7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934692AbeF1INj (ORCPT + 99 others); Thu, 28 Jun 2018 04:13:39 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:49398 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934056AbeF1INg (ORCPT ); Thu, 28 Jun 2018 04:13:36 -0400 Received: from trochilidae.toradex.int (unknown [46.140.72.82]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 93CD75C0070; Thu, 28 Jun 2018 10:13:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1530173614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:content-type:content-transfer-encoding: in-reply-to:references; bh=EUHUXhhEy2o4J5rrnu5f10WOpSCVshkBgwpdYeho8qw=; b=G+S5nWa7BC1oGg91/vREjHMw1r3w6SY//3A26XYBnkK+ZhYIIMJPGcD6/CAyILJWJDTwTV jAtA8/av1Q8/5TialYFUfJmxel2newrytQOfn3i3kHOihpaLqDWmbr5u2wTa/Rqae72Vz9 6p3TanBQkgD9HRI0gEoenrppaWg2l1g= From: Stefan Agner To: adrian.hunter@intel.com, ulf.hansson@linaro.org Cc: fabio.estevam@nxp.com, haibo.chen@nxp.com, aisheng.dong@nxp.com, michael@amarulasolutions.com, rmk+kernel@armlinux.org.uk, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Agner Subject: [PATCH 0/3] mmc: sdhci-esdhc-imx: fix no UHS modes Date: Thu, 28 Jun 2018 10:13:28 +0200 Message-Id: <20180628081331.13051-1-stefan@agner.ch> X-Mailer: git-send-email 2.18.0 X-Spamd-Result: default: False [-0.53 / 15.00]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-1.43)[91.14%]; TAGGED_RCPT(0.00)[kernel]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; MID_CONTAINS_FROM(1.00)[]; ASN(0.00)[asn:6830, ipnet:46.140.0.0/17, country:AT]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently sdhci-esdhc-imx.c sets SDHCI_QUIRK2_NO_1_8_V if no 100MHz/200MHz pinctrl configurations are present in order to prevent the stack from choosing high speed modes. This does work for SD cards quite well, since 1.8V matches all higher speed modes, and all lower speed modes run with 3.3V. However, when running a eMMC on 1.8V only, this causes issues: If vqmmc-supply is set to 1.8V only, and the driver at the same time sets SDHCI_QUIRK2_NO_1_8_V, the stack has troubls selecting a valid mode and continuously prints: mmc1: Switching to 3.3V signalling voltage failed There are already board device trees which work around this by not setting vqmmc-supply, e.g. arch/arm/boot/dts/imx6qdl-sr-som-ti.dtsi. Introducing a new quirk was the only way which I came up with, but maybe there is a better way to prevent higher speed modes while allowing 1.8V eMMC? Stefan Agner (3): mmc: sdhci-esdhc-imx: get rid of support_vsel mmc: sdhci: add quirk to prevent higher speed modes mmc: sdhci-esdhc-imx: prevent stack from using higher speed modes drivers/mmc/host/sdhci-esdhc-imx.c | 12 ++++-------- drivers/mmc/host/sdhci.c | 8 ++++++++ drivers/mmc/host/sdhci.h | 2 ++ include/linux/platform_data/mmc-esdhc-imx.h | 2 -- 4 files changed, 14 insertions(+), 10 deletions(-) -- 2.18.0