Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Jun 2018 15:19:28 -0600
From:   Keith Busch <keith.busch@linux.intel.com>
To:     Bart Van Assche <bart.vanassche@wdc.com>
Cc:     Keith Busch <keith.busch@intel.com>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/5] blk-mq: add API to get hctx index from request
Message-ID: <20180628211928.GA13810@localhost.localdomain>
References: <20180628205601.13742-1-keith.busch@intel.com>
 <57c119c3-5704-0dcb-96dd-fede99c49511@wdc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <57c119c3-5704-0dcb-96dd-fede99c49511@wdc.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 28, 2018 at 02:12:38PM -0700, Bart Van Assche wrote:
> Regarding the above patch: have you considered to use the existing function
> blk_mq_unique_tag_to_hwq() instead of introducing this new function?

Interesting. I think the usage I need using that is something like:

	blk_mq_unique_tag_to_hwq(blk_mq_unique_tag(req))

Sort of a round-about way to get to the hwq from the struct request,
but I'd rather not introduce anything new if there are other ways,
so thank you for the pointer.