Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp257762imm; Thu, 28 Jun 2018 19:32:04 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK/IpBNeDIxnzUrJUIW15Z/S8z4dbrO49fYjUdvWy549IXqXLk88Y9/z8bo5HxIPX7Ddiqi X-Received: by 2002:a17:902:a5cb:: with SMTP id t11-v6mr12932565plq.71.1530239524284; Thu, 28 Jun 2018 19:32:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530239524; cv=none; d=google.com; s=arc-20160816; b=BVGWlduwO9k7Zwv1uS253sWYOuK6282Tn4hJcOnG3Tf9ewFxHrwmOY4FqG68kX+vkH ibypVcTv90Yovnlf6kWRb2uKRo26wvYJUlZZbZs5PLpBuFw/RmEaoNM+xg6eS0rQ9fMV ehlFUFJmq5PozEymv4OCK/2vU8wNIe2/CM3iP4Mg1WdKrp6wWAU/XSauVfL0kzUx2qyr vMemY7hcW/4sVCCZ6ZF6WjSZezR9hEKmJF/hEBoKZRDC4JRDxsr9bncrenNBsOkChZfb fTBJcBw1BnXfkhjhX6HN3khJgGf33HUb+HBB7pm+uwUwVKC4TyHCA8S7gQTOdbdzuLOY d4mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=XP0P34U7xRl4YfoB2iF0c0bbZbFHfSkMZGZkCpmprnY=; b=ACWJOCq1f4oyk9p6XA0liRUHJPNQ2GsVBLm4Zv/xzV9EVY/IuUOK+Yh3unYa1DjFee Sq2BMVT/eldYVlAiDQmao9Rw50SbTmV7zkPNXxEmw1QNyoTRQZKY99ysep4owDB8TxBl CD2YQqdm+VEChsUELTSE31A0SIXxsWrnyy/eGHhZRmNu+emYh4XcAcmsabiUa+NrdPE/ XoYJdnTS5abKleI2wE3cwZCFnGWvfSG5X2vqhboTQoCq54BD1Te8+f2XY77WUYslzRK1 kEnzgv8+7q1XOQk5v1WZqu7DPo9B7i+xoosusT1jwd+7IgqOItAhUL+XFnP3KSxi5xK4 kuPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q79-v6si8600561pfk.268.2018.06.28.19.31.49; Thu, 28 Jun 2018 19:32:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967991AbeF1TDf (ORCPT + 99 others); Thu, 28 Jun 2018 15:03:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:38152 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S967119AbeF1TDb (ORCPT ); Thu, 28 Jun 2018 15:03:31 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7DFE5AD02; Thu, 28 Jun 2018 19:03:28 +0000 (UTC) Date: Thu, 28 Jun 2018 09:48:24 +0200 From: Johannes Thumshirn To: Keith Busch Cc: Sagi Grimberg , James Smart , Linux NVMe Mailinglist , Linux Kernel Mailinglist , Keith Busch , Christoph Hellwig Subject: Re: [PATCH v5 2/2] nvme: trace: add disk name to tracepoints Message-ID: <20180628074824.crqwgdlnrqt34s3d@linux-x5ow.site> References: <20180627125324.22064-1-jthumshirn@suse.de> <20180627125324.22064-3-jthumshirn@suse.de> <20180627163706.GA9361@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180627163706.GA9361@localhost.localdomain> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 27, 2018 at 10:37:06AM -0600, Keith Busch wrote: > It looks like you want the # assigned to /dev/nvme<#>. Do you want to > use ctrl->instance here instead? Right. As it'll conflict with your other trace patch do you want me to wait with the resend? Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850