Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp270631imm; Thu, 28 Jun 2018 19:53:47 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcCG/bq7mkY/+rdQ6t2hsFui1FR26NpAlKyBksmRsk59QyKEMUglGPr7fIxvXjTLaTaN/pc X-Received: by 2002:aa7:8589:: with SMTP id w9-v6mr12606780pfn.119.1530240827232; Thu, 28 Jun 2018 19:53:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530240827; cv=none; d=google.com; s=arc-20160816; b=wplFjcJ/qDx6FoVz0BOiVSn3aMPOtxWZnTJaI1T4OArAMF50OhtK5RadlynS8LSF6N u6M7ew+z75NtfG9eqJfrQDx7YbFl2zzFTxavfMOFl49EJdXXpCHFqfQxm+j6+cfyPOd0 Apj5K9nGyVBXnwDDYxOS/qdk18dvMJu5hSP/hawEy9cwWMAwriDeI82/rrs8ejhBtyNo Htxl7nf5fQrrxg/VQZ8y/sPmc8tKAk5+Fh8qSHoCSvoGIj1rsqtv4P7oxUDZRocykHzh eMGSe9jpR2XMboKCZgMdLrXU1y0pNMtL5owrULPtLn3VGmaQXxK6oQfftbQ6cGE4vOV3 XEvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=QKg90FTuSuW27iG9WkPEeAv4vw/9V5gf4/0TnS9jz5U=; b=gCTCeT0RmF8PTJmXlW4P1fZXn+fTiru+UJ88qLypj28+tzGAs+ln+N51P++ECBl8sO 08iPb4v64mKclWQKwtTUFj0Tv3rQhx7m0yvibOm6ACg22bmFSf3nUvRcajoWa4Xb0klC fbRs4J3xu6nvD/ehLO6CmUcqj1NzowMArqSuA8TcySm53g63g93Q2nvCuraPis0O9YGL CMzLLf2wKMRaVpCNTIYWFDB95/EzZSGvEBiYQyVagCZdSzyx8yXzhIvX37GWWwJbcY7z X0W8+eqAIDAzFt59YlE7Bpa8TJJtLP3ot6kxNJNy0v7tspiHOhjkAve51JxEm8oWU0Vf x27A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=L0n8QYnz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7-v6si6526242pgq.560.2018.06.28.19.53.33; Thu, 28 Jun 2018 19:53:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=L0n8QYnz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030422AbeF1SX1 (ORCPT + 99 others); Thu, 28 Jun 2018 14:23:27 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:39398 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030428AbeF1SV7 (ORCPT ); Thu, 28 Jun 2018 14:21:59 -0400 Received: by mail-pg0-f68.google.com with SMTP id n2-v6so2822114pgq.6 for ; Thu, 28 Jun 2018 11:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QKg90FTuSuW27iG9WkPEeAv4vw/9V5gf4/0TnS9jz5U=; b=L0n8QYnzMafn0UED6KfTLrCCidJg3O8fCiWdR0inqKPjetwFa8ngFimyR8hyMArhec Y54zJtlsi4uiIuFueDAln2/zyu9q29zisvPyx9umPHTggVreqMkfmYcc37I9Yna6gt+M 0KW24dn+jIgWTAKfvme8O6h8ViVyNyny4JVws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QKg90FTuSuW27iG9WkPEeAv4vw/9V5gf4/0TnS9jz5U=; b=DRbQhVlaUF1axbyJUdQi7zvXvbDWJPC2tvakq9+bGrpKs44MuDpGZ8+QeOBnkCh4Bg kxQDho+4PyyL3xgiRj/ZaCLtTrJUhspL1899LJ46gfT1WaID4KqkqPN1YOPvdGhq5PFd DVmrSTecXmChUriVLv2Drt1poeggWEk6IlrjsQxs36tFRN6CWWIZMKBTkFI9thF+uSkY dlBZL0HVIx8S/T54RnBTKJOVZMYDfOL1NtGwayrTUCIb2BqL9wjFinHIaUB674/YICPl BSJeGNMehSugT4Cy3DZ15I1C3S1rDOBl8YnneuEMT7YQRJo05HlqQEbmvzUjBqftOpIg S74w== X-Gm-Message-State: APt69E2DpQ/6aVJxdjNEhXCFDmtMPx2FhYZehnnl6aINcJrMBGhxH5Bt 4j7T2Hj+/VsRrqOd2RnoyYlv0JFhgec= X-Received: by 2002:a63:aa03:: with SMTP id e3-v6mr9792456pgf.169.1530210118745; Thu, 28 Jun 2018 11:21:58 -0700 (PDT) Received: from joelaf.mtv.corp.google.com ([2620:0:1000:1600:3122:ea9c:d178:eb]) by smtp.gmail.com with ESMTPSA id q10-v6sm13686027pfj.7.2018.06.28.11.21.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 11:21:58 -0700 (PDT) From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Boqun Feng , Byungchul Park , Ingo Molnar , Julia Cartwright , linux-kselftest@vger.kernel.org, Masami Hiramatsu , Mathieu Desnoyers , Namhyung Kim , Paul McKenney , Peter Zijlstra , Steven Rostedt , Thomas Glexiner , Tom Zanussi Subject: [PATCH v9 2/7] srcu: Add notrace variant of srcu_dereference Date: Thu, 28 Jun 2018 11:21:44 -0700 Message-Id: <20180628182149.226164-3-joel@joelfernandes.org> X-Mailer: git-send-email 2.18.0.rc2.346.g013aa6912e-goog In-Reply-To: <20180628182149.226164-1-joel@joelfernandes.org> References: <20180628182149.226164-1-joel@joelfernandes.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Joel Fernandes (Google)" In the last patch in this series, we are making lockdep register hooks onto the irq_{disable,enable} tracepoints. These tracepoints use the _rcuidle tracepoint variant. In this series we switch the _rcuidle tracepoint callers to use SRCU instead of sched-RCU. Inorder to dereference the pointer to the probe functions, we could call srcu_dereference, however this API will call back into lockdep to check if the lock is held *before* the lockdep probe hooks have a chance to run and annotate the IRQ enabled/disabled state. For this reason we need a notrace variant of srcu_dereference since otherwise we get lockdep splats. This patch adds the needed srcu_dereference_notrace variant. Reviewed-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- include/linux/srcu.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/srcu.h b/include/linux/srcu.h index 3e72a291c401..67135d4a8a30 100644 --- a/include/linux/srcu.h +++ b/include/linux/srcu.h @@ -169,6 +169,11 @@ static inline int srcu_read_lock_held(const struct srcu_struct *sp) */ #define srcu_dereference(p, sp) srcu_dereference_check((p), (sp), 0) +/** + * srcu_dereference_notrace - no tracing and no lockdep calls from here + */ +#define srcu_dereference_notrace(p, sp) srcu_dereference_check((p), (sp), 1) + /** * srcu_read_lock - register a new reader for an SRCU-protected structure. * @sp: srcu_struct in which to register the new reader. -- 2.18.0.rc2.346.g013aa6912e-goog