Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp414712imm; Thu, 28 Jun 2018 23:25:48 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdUUHbvWKlm+6pYeyTrRknPkU3Vj9YzAKgQIqGIQseW7j9vcfLTlrPdZLNQ4DYCMp/Jjyhv X-Received: by 2002:a63:2ac4:: with SMTP id q187-v6mr10172454pgq.333.1530253547966; Thu, 28 Jun 2018 23:25:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530253547; cv=none; d=google.com; s=arc-20160816; b=mk4K87VkpMpFPqZvcAzhsq4J4pnNvyKkDVM+CqgOKzI6qwVepbBJlIPsUuVbo4JNGF OMM+Pf/pfvpRvpys2umXvWDcFyovfpEZKzi7U/34rGFcBTmCww1VdBpS8B6F/RU0CfT1 SzgQwAYshK0IBJakWi/yPLfQNxeREBNjLWh/ZSOi8lddXUBQ/lqRB3AtkCoqlK4nv112 /B7mF6YfL84d86UCGAPAt4rwSEQWfQiK0+bHnQL64cThZbQrAkXgKpLZo3rquMID2opz 76gUmZmvFtoZr+lX261T/6hKR8LQiLCyChGpRu31gsuXCOckNd+YJ3sIlJe2eaQQdYuz mI6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=98iFtNlRr0+oFMA0NTgbIFn2x6J3/7KaXJbTNzBodHY=; b=ULBMNdmMlOCnH1vYltH9eBo7+AaQtv5cOAOLyuxgP+rySh7giz2A7zuBgVxQUWk/7p MAp8RRYKfCNwuskVZcCwVAi0gFJJ/U/mBRCBy6gZyuqwcJrNu/nWHKJzZnpDy4sWr+Po ++k0Ez+h7B33vp6GPUxN4sdrHnwXvPk3BHA0tDusgDMgX14YZMmrzrsXs5STSpsE52sc OSq+V3zHeBGn5MuYx6xJP356OHl880DX69B0tPFlSZP0wlZNmWcvzNjLy5TYy/VNTaWY /pYIioAcVeBB28+8kH4mdCCM3eiO+bmOxqkTpD7WZkBKfvoq1BCzV7oPXuSroosRsOor 0sKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3-v6si8427000pfi.230.2018.06.28.23.25.33; Thu, 28 Jun 2018 23:25:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936092AbeF1WjL (ORCPT + 99 others); Thu, 28 Jun 2018 18:39:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:43148 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934984AbeF1WjK (ORCPT ); Thu, 28 Jun 2018 18:39:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5BE2CAD2D; Thu, 28 Jun 2018 22:39:08 +0000 (UTC) Date: Fri, 29 Jun 2018 00:39:06 +0200 From: "Luis R. Rodriguez" To: Waiman Long Cc: "Luis R. Rodriguez" , Kees Cook , Andrew Morton , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Al Viro , Matthew Wilcox , "Eric W. Biederman" , Takashi Iwai , Davidlohr Bueso Subject: Re: [PATCH v8 2/5] ipc: IPCMNI limit check for semmni Message-ID: <20180628223906.GB331@wotan.suse.de> References: <1529317698-16575-1-git-send-email-longman@redhat.com> <1529317698-16575-3-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1529317698-16575-3-git-send-email-longman@redhat.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 18, 2018 at 06:28:15PM +0800, Waiman Long wrote: > For SysV semaphores, the semmni value is the last part of the 4-element > sem number array. To make semmni behave in a similar way to msgmni and > shmmni, we can't directly use the _minmax handler. Instead, a special > sem specific handler is added to check the last argument to make sure > that it is limited to the [0, IPCMNI] range. An error will be returned > if this is not the case. Sorry my time has run out, and will be on vacation until July 10th. If this can wait until then then great, otherwise hopefully Kees can take a look. It would be wonderful to get Eric's review on this as well. Luis