Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp446692imm; Fri, 29 Jun 2018 00:07:25 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIU2iBaFX/3oJhNZYIKOGiCDctggwwaskEcsnzusipBBuKmpY8E/6HkhX6Cj3CRt3/Y0HKs X-Received: by 2002:a65:5581:: with SMTP id j1-v6mr11873160pgs.203.1530256045583; Fri, 29 Jun 2018 00:07:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530256045; cv=none; d=google.com; s=arc-20160816; b=pAiQcKXSXPsQjPytUsrV5tGgpVLV44tAf97bkGahIEYVvLluQBBUGOQB3sz7oHxvw7 wLUENAOt5jjePT1b8ig7VhcyJtS9+L0CX6cB+OyfuUYivgjEf5xPfRIg02WLiO42wb0c UkDgo8hPkOUPUHBD4iL/t/6Yv+sK8nAf6MSaYecYuixM/8dkc78aurHA7ua1ndADys/K wNWn7W3Rb/So3iEcmlXS7yVXF9kx9srdxozed6udbJ0hcJABkc630kl+91NWtP3OFO/H c1zbnXXljefKbUvNXG5AOpl6XCJ4nKb+6axKmX4NUCsFQSxJmTvo/D324jK9jOcUUyqe stnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=+Jy+DzfqU9I0iBCIPQQRdQd5XQzgmxw4O2/lcuWTl90=; b=jkSR65eDci2kPvPTCp9+MTzW5FFssthxfAEj2PVq0LhChuYMwp4oIruWnDB4E3j1v6 +z5h3K2/vEQuLGNw7okJJAjv9DYNomafr9uvxrnzi8Kk6V7XQK0Jx567+q3hQbZTGza3 UpqZrxgGAI2XOJM8UGeYhsRYOfu+BxiMkkVcnOg9WMyiX+Hsnr9GbWNmf1wDX4DdhSrl JXtlE+IvJ/bDP+eT8mAPLk0ipz/ZlGMi0wjc89rbqhztwm558slo/vehAOTS05pCKR5F 1WvOc9UFhbLsrfeYgoCQY/jFBjt0wjenidxtQafInj3x06KxD3BZzMgA0lsq4UWL9XOr CsoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=d7FrFujc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x19-v6si8508077plr.15.2018.06.29.00.07.11; Fri, 29 Jun 2018 00:07:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=d7FrFujc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753941AbeF2GES (ORCPT + 99 others); Fri, 29 Jun 2018 02:04:18 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:54414 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753116AbeF2GER (ORCPT ); Fri, 29 Jun 2018 02:04:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+Jy+DzfqU9I0iBCIPQQRdQd5XQzgmxw4O2/lcuWTl90=; b=d7FrFujc3f6cGLZfhCLeCK9Pt KaLyXTepcoJJONDr6qbffcxcjfVy3XMHcKosnnus72PCfEygi7XfwXo2KeqGSylun31Ir9hPjWN5P LGS2HdPt8vJfBEAIvIF+UOqFQq/x53EJwmD4oFlm0fbF5+Zy8DEb/3ZlkZc/XcstNFv027lAv1APm opRtoUwKdoxpQCEsEVivv7CwIXV0+3vMlfe8+pswCJROqRIjFXwkWKuw+rlehoMuOdDzTmYd29S7R WLj9ThTDMFbLXQxpyYaqE7I3BFNjkhdkR4FcQZlO7340JX9kROlHRS0RGVkHBOxYmjIAUqkB5N/wD W6wVhoa4A==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fYmVw-0006mr-6n; Fri, 29 Jun 2018 06:04:12 +0000 Date: Thu, 28 Jun 2018 23:04:12 -0700 From: Matthew Wilcox To: "Huang, Ying" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" , Andrea Arcangeli , Michal Hocko , Johannes Weiner , Shaohua Li , Hugh Dickins , Minchan Kim , Rik van Riel , Dave Hansen , Naoya Horiguchi , Zi Yan , Daniel Jordan Subject: Re: [PATCH -mm -v4 03/21] mm, THP, swap: Support PMD swap mapping in swap_duplicate() Message-ID: <20180629060412.GI7646@bombadil.infradead.org> References: <20180622035151.6676-1-ying.huang@intel.com> <20180622035151.6676-4-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180622035151.6676-4-ying.huang@intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 22, 2018 at 11:51:33AM +0800, Huang, Ying wrote: > +++ b/mm/swap_state.c > @@ -433,7 +433,7 @@ struct page *__read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask, > /* > * Swap entry may have been freed since our caller observed it. > */ > - err = swapcache_prepare(entry); > + err = swapcache_prepare(entry, false); > if (err == -EEXIST) { > radix_tree_preload_end(); > /* This commit should be just a textual conflict.