Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp455894imm; Fri, 29 Jun 2018 00:19:33 -0700 (PDT) X-Google-Smtp-Source: AAOMgpesvtAvZF96HQt9XSggS1a5P3BMQGAqBSXdFhceo9/jwUTrXjvuQCSlOhLOAEZB16SylEFy X-Received: by 2002:a62:4bc6:: with SMTP id d67-v6mr7024619pfj.175.1530256773883; Fri, 29 Jun 2018 00:19:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530256773; cv=none; d=google.com; s=arc-20160816; b=pBB7IfkmBU9ZWD/mIDT/O9u1Dw/sZgV9CmVD0eMTj+yZxXiFilnHdXPiEfY0hEmd4x fKKu/Qymu2MS3rj4t/QYxMbNGgJWYhlRg0rJePPoLmO6nznKkL5GiYZ861cniCmOO1zo BbM9HP1rG35BYy/KdtcYbj9FcgKDXIY/CVll30Enb8XupyDspPNFvzgN6GqUYemFAoFc EmwWyWFULEJts8czE8DtwJDSNupUa2KUH+NxxIqFI2otlsLYpTiwP8mLRqYLarcs4b8E BqOD9bYTtdeYc/KdB759HM+ek6BxC7sTm4aH5rFpRTkXXhjMno6J2SXZfhjhMzH0baJC Wd4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:arc-authentication-results; bh=aTRiclXBOh5eq8lC3fcSvEUpFT0z2l87pg/3NAT501E=; b=l+dYw6uRYw44yXih8cOdTboZgbhtsZ4N556H6Usl24tclqPzNu4hzKfwUUhMcG1Qzk 3YNKqVuM2rlUjNRpueuU3bperi78XoartlWNbodTcb+MI4XTpN2WRuOlqZGk0nL9Wg9D nGziMJHAqYePjb7xAo8lRXXPzAtG3kD2IlQdIPhVS/RO8jk0Rr2Ga8PQzhlhAt6lZ2L+ 2Swqrp6S8BMXlYuhta4nfHW+XVmyALvob5mcUz6SIP8D6Lpi+ajkDiVLxRrpriSuEEfZ hM15XHFKItmr1QWr1/EkmE4H405jzd5Cs4W4bMN1ZOOLgYP67foyHuCC8GXq+7yha7mk InZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1-v6si7556432pga.296.2018.06.29.00.19.19; Fri, 29 Jun 2018 00:19:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753900AbeF2Git (ORCPT + 99 others); Fri, 29 Jun 2018 02:38:49 -0400 Received: from mga14.intel.com ([192.55.52.115]:55333 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbeF2Gis (ORCPT ); Fri, 29 Jun 2018 02:38:48 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2018 23:38:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,285,1526367600"; d="scan'208";a="53815010" Received: from pipin.fi.intel.com (HELO localhost) ([10.237.68.37]) by orsmga006.jf.intel.com with ESMTP; 28 Jun 2018 23:38:44 -0700 From: Felipe Balbi To: linux-usb-owner@vger.kernel.org Cc: Zhouyang Jia , Greg Kroah-Hartman , Vincent Pelletier , Johan Hovold , David Lechner , Bhumika Goyal , Andrew Gabbasov , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] usb: gadget: add error handling for skb_realloc_headroom In-Reply-To: <1529410988-70261-1-git-send-email-jiazhouyang09@gmail.com> References: <1528778503-41615-1-git-send-email-jiazhouyang09@gmail.com> <1529410988-70261-1-git-send-email-jiazhouyang09@gmail.com> Date: Fri, 29 Jun 2018 09:36:10 +0300 Message-ID: <87vaa2drqd.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, linux-usb-owner@vger.kernel.org writes: > When skb_realloc_headroom fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling skb_realloc_headroom. > > Signed-off-by: Zhouyang Jia from linux-usb-owner@vger.kernel.org?? -- balbi