Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 29 Jun 2018 10:00:08 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Keith Busch <keith.busch@intel.com>
Cc:     Johannes Thumshirn <jthumshirn@suse.de>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 4/4] nvme: add disk name to tracepoints
Message-ID: <20180629080008.GB13413@lst.de>
References: <20180628214956.13877-1-keith.busch@intel.com> <20180628214956.13877-5-keith.busch@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180628214956.13877-5-keith.busch@intel.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> +const char *nvme_trace_disk_name(struct trace_seq *p, char *name)
> +{
> +	const char *ret = trace_seq_buffer_ptr(p);
> +
> +	if (name[0] != 0)
> +		trace_seq_printf(p, "disk=%-.*s, ", DISK_NAME_LEN, name);

	if (*name)
		trace_seq_printf(p, "disk=%-.*s, ", DISK_NAME_LEN, name);

?

> +		    req->rq_disk ?
> +			memcpy(__entry->disk, req->rq_disk->disk_name, DISK_NAME_LEN) :
> +			memset(__entry->disk, 0, DISK_NAME_LEN);

Make this a helper please.