Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp567292imm; Fri, 29 Jun 2018 02:42:44 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI+l4uJ+JwpNyBQMwqNqD2VX+H1IDV5AKuDrVIrZVKGUdYhuuj82KPmyE4aX8QHWq4Tjw1Q X-Received: by 2002:a63:2c94:: with SMTP id s142-v6mr11700045pgs.39.1530265364136; Fri, 29 Jun 2018 02:42:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530265364; cv=none; d=google.com; s=arc-20160816; b=uzosjYr6u9LO7VlxbHrq86//ww1FV184CB8d4gdXttZDPaQTYGQWUm9TmLlnXPHjji V4u3tae0m3NBpxRLvDn7z0IbKkq24gg6orVTO24mArmiiDLKihyWWCQZ5UEEX8UkgR9s OiOX6i57N6DJe16B0VdUI8UyWQTkPQuFHniFW4qUue2xGCblEyrLubmczfDFlKcWFbuZ OX40Z+sc7d6+9IPuaLFYmY8TRU1KaPcvT+YfXriyoWDf/o2bzN8UTtk4Rql/urimrP4T si8LusO0JSL2degrxt+BE+zUJ9KMEWRdsD6Eya+f23BLsKUbgnXAfW8qgybb2+3U9aju 08HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=GTQTWzVj+w34pTdO9ou1Ci/poFKn8CcYpvyPNYktK3s=; b=H6Wa9f6DdefknSldZAfaM1ibnitGQiUnYxV2YLKo2Jr/pmXdj2qYVLy6gN6oG40rAo Lp+PSUwHCbYchr1MHP6stRrMXWlKZO77mkaasKGbe9S2FeU64ONk60b2GBvu/cLl81UC N98vqrTwPmrVbiF2dekxwmTdHD11SnieeqhKQ6s197Z5ovE3DJGiGYVx5kaSEdZvaDsg bwzFKbDBHZiZphg90ORFcgErH+C+tz0tGwYtTOaxTs6+sZeofLGIzCgSJQ22iIW+M/qj nQpQqx6yjdMBtIkjaU5k8xaf82ZsqUqr/bOfbHXfOe+GAsAg+a17XZ39xZLgPUgkSW0W 67+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CFWM8z+y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b4-v6si7996752pgw.50.2018.06.29.02.42.30; Fri, 29 Jun 2018 02:42:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CFWM8z+y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932492AbeF2HIs (ORCPT + 99 others); Fri, 29 Jun 2018 03:08:48 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:34288 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932332AbeF2HIq (ORCPT ); Fri, 29 Jun 2018 03:08:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GTQTWzVj+w34pTdO9ou1Ci/poFKn8CcYpvyPNYktK3s=; b=CFWM8z+yEb45kRxo2qFWvVrcD 9D3RHuicBpokGQv3/+ZpZ9rD+rslAtm1ZDOm/ymwzvPKOZOUBlpc3QPIRp6/PtFdfn+DXHmMaFukV bR+8hEz9g0T+8cs0PVMsGySNLlGHBB+QpKgsLc6MNonvwVYWhCQvClAA9hTNp3cKcMCGCSsPKwpEi uKP3u0HK69cH9+UsF3TSpy0ipr9bl43A0s0vnMb2wsamhxLCvEdf7yqZT0KwKVDI8sCfrgDx7Hhml 8NDdPCyGg/9NmLaep44Bq9GPaxoV1Riyd+bTU6HCAdgkumDiIsqGW2M0ARjNY/x3e5I4WKOXQigW4 9mS7bw6JA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fYnWO-0003ZL-Iv; Fri, 29 Jun 2018 07:08:44 +0000 Date: Fri, 29 Jun 2018 00:08:44 -0700 From: Christoph Hellwig To: Zong Li Cc: palmer@sifive.com, hch@infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, zongbox@gmail.com, greentime@andestech.com Subject: Re: [PATCH v2 2/4] RISC-V: Select GENERIC_UCMPDI2 on RV32I Message-ID: <20180629070844.GB12956@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 25, 2018 at 04:49:38PM +0800, Zong Li wrote: > On 32-bit, it need to use __ucmpdi2, otherwise, it can't find the __ucmpdi2 > symbol. > > Signed-off-by: Zong Li Looks good, Reviewed-by: Christoph Hellwig