Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp568527imm; Fri, 29 Jun 2018 02:44:19 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLbrlj0Qf7XEMiMOUItpSLG4vTRbsoF6Ofz0JpmCP7u5KfqAz+UxJKxruVZxN3bMdozKbbk X-Received: by 2002:a63:7d4c:: with SMTP id m12-v6mr11815232pgn.201.1530265459658; Fri, 29 Jun 2018 02:44:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530265459; cv=none; d=google.com; s=arc-20160816; b=STlrzDTzzZf32qZbNVrUz+XdwmK26+Tq5QcVGvb9yv/dY+vTnS5PpAcRc6AvuvHyjp TT3WVeFX/iPC24afqjlfmLJ6KI+B5QjbZS1BrpWnJwi0gzQh0OgWVsvc/J90S1/qkdFN xOjRW+cJgw5ZCEMO/Dr5XGt1bSikcbeAJlNPE6fNtPTG0cqEiTs8ydyzI1Cmemxu5lGQ EbSf1jEX2FzKyvXcZ4UkA/IZVf4/yOfoodWyvG1dnXdVdcY1NiPWU+nQEXRWVVCPpk44 F+x5zMmeHR4kPhUsg6AAJIqL5pJCKHdyfnSqhUxRFIl5jmgTvmmQATzQcAN+ApXM1rcx ba0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :arc-authentication-results; bh=vpFOInBz0b8bQBufjxPowJzZ+k0hOAC1N7IQaC+9Ces=; b=HeyswEH8UB9ncgclSe2sO4tDwLjkEVFF49S7j/Sduh+ZH6n2H/+5C6mqQei+ccBqgf C706tzaOzPL1V1juLGqkimoo2UiEm9g9gJxB2hGVyvMlzVgXU5kDGdfdGRlU5jxSXpi6 /S9bCiT8b6YmBImqdWVWN7k1hHpUlhqgdFEnQptOPqJE7aGt38/l9IoqNWbdLjeQV4AQ ND7Y/kN+5DOJJWvwOVBCifd86THr3p/NKy3/1Y4noa4Hpi/2Z9Yamkr0q9C4ZjiorhnX Z701pCJ7KokENmS98HgSAZr2wPqcGG0NJBAeu+Dj2FrvacDUfGMZnUT2gB2j+4DrEo3n ZtSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11-v6si8395691plq.33.2018.06.29.02.44.05; Fri, 29 Jun 2018 02:44:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753582AbeF2H03 (ORCPT + 99 others); Fri, 29 Jun 2018 03:26:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1675 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbeF2H01 (ORCPT ); Fri, 29 Jun 2018 03:26:27 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 52E90307CF31; Fri, 29 Jun 2018 07:26:27 +0000 (UTC) Received: from llong.remote.csb (ovpn-116-112.phx2.redhat.com [10.3.116.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5CA8277343; Fri, 29 Jun 2018 07:26:24 +0000 (UTC) Subject: Re: [PATCH v8 2/5] ipc: IPCMNI limit check for semmni To: "Luis R. Rodriguez" Cc: Kees Cook , Andrew Morton , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Al Viro , Matthew Wilcox , "Eric W. Biederman" , Takashi Iwai , Davidlohr Bueso References: <1529317698-16575-1-git-send-email-longman@redhat.com> <1529317698-16575-3-git-send-email-longman@redhat.com> <20180628223906.GB331@wotan.suse.de> From: Waiman Long Organization: Red Hat Message-ID: Date: Fri, 29 Jun 2018 15:26:23 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180628223906.GB331@wotan.suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 29 Jun 2018 07:26:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29/2018 06:39 AM, Luis R. Rodriguez wrote: > On Mon, Jun 18, 2018 at 06:28:15PM +0800, Waiman Long wrote: >> For SysV semaphores, the semmni value is the last part of the 4-element >> sem number array. To make semmni behave in a similar way to msgmni and >> shmmni, we can't directly use the _minmax handler. Instead, a special >> sem specific handler is added to check the last argument to make sure >> that it is limited to the [0, IPCMNI] range. An error will be returned >> if this is not the case. > Sorry my time has run out, and will be on vacation until July 10th. If > this can wait until then then great, otherwise hopefully Kees can take > a look. It would be wonderful to get Eric's review on this as well. > > Luis Thanks for the review. I will try to get other reviewer to chime in. Kees and Eric, do you have comments on this patchset? Cheers, Longman