Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp630474imm; Fri, 29 Jun 2018 03:55:18 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdeHdWuUXQuUIvotTSxeOKh5eFsWv1EZcja30r++qtu+scDnIj4QdX6kMr4TvW04aHzg7DI X-Received: by 2002:a62:3481:: with SMTP id b123-v6mr13992060pfa.4.1530269718220; Fri, 29 Jun 2018 03:55:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530269718; cv=none; d=google.com; s=arc-20160816; b=N286PcrlWk524Jmdl88xJ8Iq8M8egUZaIwC/S1ntjQEb95O3bgd0aZ+XpfYQ0xrufF o+KyY+eWqGG386vsirgXxGwNaswH2hFUDmkZtKgwgzsvnR7AcTYoRJ4rQogHmNgOLDrm p3R6HR3aG8qcVT2A4DX3AeCo0XWq01UUVfa9+U/wm4SOj0+ORpVoqKLMNyTUBOsjbnMC 641vr24Ce6KoZXAt6sX+VvHZ44fU83/dejM/jcfinDk+m4uL1M2eLSA+seIhuMXOPIFR mrgyw8MpkxKGsh+Dnjz4XXy0C01bVylxJZT0wuNwxvmZXjP3ESYxR+9QIKnEl9nkrVyq KIDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=E2y8MgkWYIrvlucom96B5jepIho/wY0LFgxB87sKUmE=; b=aBUcn2d6XWfIfADhnqLcjNsUEs2EJcT+mxkZoDnQdhBY6+2Vj6tx1xxAq5gci/YuM7 EaTpxhAL1uDQHLVfZ+ZDdXf1Iy/n+VpvpnTFt+FSQarLs/n1KDPQPwmowD5fpjgd+rY8 Qvk8XMVFgcWOanU7siNz+zshnWYs0zTDmwrho29Hvqgu2bavYjCYhgUFkwWpSLDlvoFv SkpzwwW3G6NbuVEQH9X6DQfGI5iXUHo+lbnCRmMw0UMbEbC0r0Kc/PLW7LBx3J1MRbgP cgcqMIqf9iDTa9h0ro6LzodGY5yZTd/XUNs/obRZwhR3I2goHbSkTWAONenxyOVsmVYS 6pXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=RmQgEejr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i64-v6si8852446pli.431.2018.06.29.03.55.03; Fri, 29 Jun 2018 03:55:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=RmQgEejr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401AbeF2HMC (ORCPT + 99 others); Fri, 29 Jun 2018 03:12:02 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35698 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbeF2HMB (ORCPT ); Fri, 29 Jun 2018 03:12:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=E2y8MgkWYIrvlucom96B5jepIho/wY0LFgxB87sKUmE=; b=RmQgEejrQLjYn58EPqD8BaAR5 UVgxL1SYKWRZS+7QOOz2RR2AFycDQqtrhH9rM4kVVWN37xmVx9cAbZ+jlI+ozyLisYqs+IH+D54BP 0jMBJ4AxUsufaPi3n6cdZ441QfFaBdKb/SA4sVYb9VwP93pKkdGe4pVslsNav24iifC1MTbw9XPA/ 44tlGtD1wGe/4zISRKfW2AdeCb4poJOJHkxUf/6UWD/CGBvcz7OFyuBZ45UBpWskcepkKk5QI/mZE eZOJRCN4QTdKzIEB9oTKiUI7foXjxZOSnY8Yau2RbNn7nWcwE2HzqdDs5TRrcyKNlATPmwOB2yyn7 8XHQ8oyUw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fYnZY-0005FP-Rb; Fri, 29 Jun 2018 07:12:00 +0000 Date: Fri, 29 Jun 2018 00:12:00 -0700 From: Christoph Hellwig To: Zong Li Cc: palmer@sifive.com, hch@infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, zongbox@gmail.com, greentime@andestech.com Subject: Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index and type for 32-bit Message-ID: <20180629071200.GC12956@infradead.org> References: <4c4def99db5e0392238947dc878c5018cc7aca3e.1529915117.git.zong@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c4def99db5e0392238947dc878c5018cc7aca3e.1529915117.git.zong@andestech.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 25, 2018 at 04:49:39PM +0800, Zong Li wrote: > Use generic marco to get the index and type of symbol. Why do we even need this in a uapi header? Shouldn't ELF_RISCV_R_SYM and ELF_RISCV_R_TYPE move to module.c? In that case we could just use CONFIG_64BIT.