Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp669307imm; Fri, 29 Jun 2018 04:32:58 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeuzaM61f5YyEZwU6aK86PZsmdA/ebLeLAYgnx7L7vHaPvQ79E8IjubKLQi1tncCufPmz7q X-Received: by 2002:a62:42d7:: with SMTP id h84-v6mr10591517pfd.146.1530271977967; Fri, 29 Jun 2018 04:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530271977; cv=none; d=google.com; s=arc-20160816; b=LGQD9aSoE/tFegAWUrNafE/iYotCF1fvoqG/lOPzQ8nNtot3QuJYFTAePR9GONSiXC sPv9ktJEQMNbKsCJCAOhBlClMYIQxd4G9sUZYqoKJYrZrimZYjC1g0T1c+6xwj/OOBoV pVApnXtoJ0Jzys6ojdRzlV3FQv60Wu9W7NfTKTSkx+xpA1YSK8vy+2rsANb1Ysb/Daom 0tHzahCLLESvGVcf+4g85xTtRvBYP+df8F3tH1j2LHyXJia/SAx/ODhTlPQg5voNDrP6 8oGZDBmAYpYiz0sAoFurh9sW5uldJQTmaX9ne0gJIkp8qC37HJebdl5Jpp/H0BaMqOX+ 6B9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:to :from:arc-authentication-results; bh=K4mPzbiXghEX0expllzDNPqFqJLGCpcEqB87XnqESOY=; b=moyUBFo8YQ57K9u3wj8c/Yl+TyjKZfAkb2hok8NmUXiSxZTa6Bm3HtQ/kOy82rJdJU cty2eUf/iBNp+iFJ8tDf9Xz7i6SgaZ10HG5LG6nD9h8DtvRiPCSU0uf7IdmdaNlOp9zo Uxha206A75rrKSzWYYmt5qcPy3sQxWRgTc4McP4lLBNfLBDghj6NA1NYv3kkzNxW2ch/ mJD4u9w/Q4gJMwpe5ObrrG/uCNrAT3D/keqwdcP5sDeF2uTOrX+vbeKBkrJjfJbVcpnc dMFQDOFqgSFMZ0O/H7rO0EDJleOTtr4DGa0S4yu4qzLvdDigSnUlcfU5H7azlptqLQ2a G0uw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f5-v6si4828739pfg.165.2018.06.29.04.32.43; Fri, 29 Jun 2018 04:32:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755322AbeF2LWu (ORCPT + 99 others); Fri, 29 Jun 2018 07:22:50 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:5115 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752226AbeF2LWs (ORCPT ); Fri, 29 Jun 2018 07:22:48 -0400 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w5TBJRk7018304; Fri, 29 Jun 2018 13:22:39 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2jwjhg0ck7-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 29 Jun 2018 13:22:39 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4551E3A; Fri, 29 Jun 2018 11:22:38 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas21.st.com [10.75.90.44]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2F5DA2937; Fri, 29 Jun 2018 11:22:38 +0000 (GMT) Received: from SAFEX1HUBCAS23.st.com (10.75.90.47) by SAFEX1HUBCAS21.st.com (10.75.90.44) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 29 Jun 2018 13:22:38 +0200 Received: from localhost (10.201.23.68) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 29 Jun 2018 13:22:37 +0200 From: Yannick Fertre To: Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Vincent Abriou , David Airlie , , Subject: [PATCH] drm/stm: ltdc: rework reset sequence Date: Fri, 29 Jun 2018 13:22:35 +0200 Message-ID: <1530271355-5608-1-git-send-email-yannick.fertre@st.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.201.23.68] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-29_03:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reset must be properly assert before deassert. This is important if there is an early boot splash screen before the kernel start up. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 96d20c2..8f4606d 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -1130,8 +1130,11 @@ int ltdc_load(struct drm_device *ddev) } } - if (!IS_ERR(rstc)) + if (!IS_ERR(rstc)) { + reset_control_assert(rstc); + usleep_range(10, 20); reset_control_deassert(rstc); + } /* Disable interrupts */ reg_clear(ldev->regs, LTDC_IER, -- 1.9.1