Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180629142710.2069-1-michel@daenzer.net>
References: <20180629142710.2069-1-michel@daenzer.net>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 29 Jun 2018 10:50:15 -0400
Message-ID: <CADnq5_NZa=-_Cs6zq=0kk-A9VKa=56Sbg+dUrgdvB5vz77SAnw@mail.gmail.com>
Subject: Re: [PATCH] drm: Use kvzalloc for allocating blob property memory
To:     =?UTF-8?Q?Michel_D=C3=A4nzer?= <michel@daenzer.net>
Cc:     Gustavo Padovan <gustavo@padovan.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 29, 2018 at 10:27 AM, Michel D=C3=A4nzer <michel@daenzer.net> w=
rote:
> From: Michel D=C3=A4nzer <michel.daenzer@amd.com>
>
> The property size may be controlled by userspace, can be large (I've
> seen failure with order 4, i.e. 16 pages / 64 KB) and doesn't need to be
> physically contiguous.
>
> Signed-off-by: Michel D=C3=A4nzer <michel.daenzer@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/drm_property.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_propert=
y.c
> index 1f8031e30f53..cdb10f885a4f 100644
> --- a/drivers/gpu/drm/drm_property.c
> +++ b/drivers/gpu/drm/drm_property.c
> @@ -532,7 +532,7 @@ static void drm_property_free_blob(struct kref *kref)
>
>         drm_mode_object_unregister(blob->dev, &blob->base);
>
> -       kfree(blob);
> +       kvfree(blob);
>  }
>
>  /**
> @@ -559,7 +559,7 @@ drm_property_create_blob(struct drm_device *dev, size=
_t length,
>         if (!length || length > ULONG_MAX - sizeof(struct drm_property_bl=
ob))
>                 return ERR_PTR(-EINVAL);
>
> -       blob =3D kzalloc(sizeof(struct drm_property_blob)+length, GFP_KER=
NEL);
> +       blob =3D kvzalloc(sizeof(struct drm_property_blob)+length, GFP_KE=
RNEL);
>         if (!blob)
>                 return ERR_PTR(-ENOMEM);
>
> @@ -576,7 +576,7 @@ drm_property_create_blob(struct drm_device *dev, size=
_t length,
>         ret =3D __drm_mode_object_add(dev, &blob->base, DRM_MODE_OBJECT_B=
LOB,
>                                     true, drm_property_free_blob);
>         if (ret) {
> -               kfree(blob);
> +               kvfree(blob);
>                 return ERR_PTR(-EINVAL);
>         }
>
> --
> 2.18.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel