Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp922022imm; Fri, 29 Jun 2018 08:29:39 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLfRTX3RtfqyCSkxj6+pW1y0jSJjOGxwop/Mpr2B68EBPrAnvKkXoBGw3aMTqq8ma1o9VQv X-Received: by 2002:a63:85c8:: with SMTP id u191-v6mr13015699pgd.36.1530286179297; Fri, 29 Jun 2018 08:29:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530286179; cv=none; d=google.com; s=arc-20160816; b=0w4njQv1YDG/pPJgtjzQ/y2+Wlj8p6Yt+2ie4jXL21g3g2XygYdHW1jfzdQx1Ra8tw nTPciDCB5d5m4HEDV3J2DlNCp/SLvsgIcT34lL00vWJZIZlrDfH8SrNbqXCOQhtiKzoV aKr3G8O8rezQeT+12iQvUm/WEuQ6kpEQ7GLVE6mAYlU75Ic4S2TYAEkzLun+mtRdSclP 7bFPeB3xPk02CBQGHB/uCMHKJMglN8XxeZWtr0L3huVgalsen7wI6IUcobR+28KpSrqo Dk2m/WwNjCpMkdb8aF/bqazAsl5cFs+A/IgiK24LzW/ZZye+vpmRhhq8LcirSmP5lBRo CXJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=+fQWUnptD6RfnWJ8FyJXBh9g4Eyl+OKq42daxxmMtfI=; b=vrJ2Ka4AFXdb07H6MTNf+TqHpN8wehIbYO3emSWdB7KhpbEYH7Om9dYdE9Z5RVSXjG oPtWNyuKguG7Ct5v5lbuDsULaxT3gxu09g8E1yWg0HyfjC8ZBABgm7VOFqEqYakLvsQb nMSm39+M0u8lhoPvXt2Q4gxZLkgM1hII/khuNYmzlP+fUOIFTRtRypwb1RrQRSEh6Lmr 9FKmlkcqmj5HRQpYNIChMn85kyhGg862P8GEE0/FzpoCIZg7JVSvjpajwkKWXL5764eB aMYn9NZyAwPEQbG0ufZCaGmVLz1GHKdIrIb99hIJD6HgIaDdJ7fXw2eiiO65XegqXGkT MRTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a4-v6si9262020plp.219.2018.06.29.08.29.25; Fri, 29 Jun 2018 08:29:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966164AbeF2Nvh (ORCPT + 99 others); Fri, 29 Jun 2018 09:51:37 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:9750 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966099AbeF2Nvf (ORCPT ); Fri, 29 Jun 2018 09:51:35 -0400 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w5TDmwFZ007522; Fri, 29 Jun 2018 15:51:13 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2jwke40q4x-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 29 Jun 2018 15:51:13 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id CD1B642; Fri, 29 Jun 2018 13:51:12 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag6node1.st.com [10.75.127.16]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4AA002D2C; Fri, 29 Jun 2018 13:51:12 +0000 (GMT) Received: from [10.48.0.237] (10.75.127.47) by SFHDAG6NODE1.st.com (10.75.127.16) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 29 Jun 2018 15:51:11 +0200 Subject: Re: [PATCH 00/19] mmc: mmci: add stm32 sdmmc variant To: Ulf Hansson , Rob Herring CC: Maxime Coquelin , Alexandre Torgue , Gerald Baeza , , , , References: <1528809280-31116-1-git-send-email-ludovic.Barre@st.com> From: Ludovic BARRE Message-ID: Date: Fri, 29 Jun 2018 15:51:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1528809280-31116-1-git-send-email-ludovic.Barre@st.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG6NODE1.st.com (10.75.127.16) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-29_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi Ulf I know that you very busy on other task, but did you have time to look my serie. do you have first feedback ? BR Ludo On 06/12/2018 03:14 PM, Ludovic Barre wrote: > From: Ludovic Barre > > This patch series adapts mmci driver to add support for stm32 > sdmmc variant. stm32h7 SoC integrates the first revision of > stm32 sdmmc. > > This series is composed of 3 parts: > -Prepare mmci driver to manage dma interfaces by adding property. > New mmci dma API is defined according to the legacy needs. > -Adapt mmci driver to dedicated constraints of stm32 sdmmc variant, > defined under some specific properties. > -Add stm32 sdmmc variant. As Internal DMA way satisfies data > transfer, the mmci driver hasn't been modified for pio_read/write. > Specific adds-ons to stm32 sdmmc: > + registers > + clk/power functions > + idma interface > > Ludovic Barre (19): > mmc: mmci: regroup and define dma operations > mmc: mmci: merge qcom dml feature into mmci dma > mmc: mmci: add datactrl block size variant property > mmc: mmci: expand startbiterr to irqmask and error check > mmc: mmci: allow to overwrite clock/power procedure to specific > variant > mmc: mmci: add variant properties to define cpsm & cmdresp bits > mmc: mmci: add variant property to define dpsm bit > mmc: mmci: add variant property to define irq pio mask > mmc: mmci: add variant property to write datactrl before command > mmc: mmci: add variant property to allow remain data > mmc: mmci: add variant property to check specific data constraint > mmc: mmci: add variant property to request a reset > mmc: mmci: send stop cmd if a data command fail > mmc: mmci: add clock divider for stm32 sdmmc > mmc: mmci: add stm32 sdmmc registers > mmc: mmci: add DT bindings for STM32 sdmmc > mmc: mmci: add stm32 sdmmc idma support > mmc: mmci: add specific clk/pwr procedure for stm32 sdmmc > mmc: mmci: add stm32 sdmmc variant > > Documentation/devicetree/bindings/mmc/mmci.txt | 11 + > drivers/mmc/host/Makefile | 3 +- > drivers/mmc/host/mmci.c | 846 +++++++++++-------------- > drivers/mmc/host/mmci.h | 237 ++++++- > drivers/mmc/host/mmci_dma.c | 780 +++++++++++++++++++++++ > drivers/mmc/host/mmci_dma.h | 33 + > drivers/mmc/host/mmci_qcom_dml.c | 177 ------ > drivers/mmc/host/mmci_qcom_dml.h | 31 - > 8 files changed, 1410 insertions(+), 708 deletions(-) > create mode 100644 drivers/mmc/host/mmci_dma.c > create mode 100644 drivers/mmc/host/mmci_dma.h > delete mode 100644 drivers/mmc/host/mmci_qcom_dml.c > delete mode 100644 drivers/mmc/host/mmci_qcom_dml.h >