Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp971380imm; Fri, 29 Jun 2018 09:14:06 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcYR2gWgZ1qaAm69YcmcsiWpOzClv1kjodr/DKdNBE63KBEb/Th9lXrWMsYtJ+R46WXbsYc X-Received: by 2002:a65:5b45:: with SMTP id y5-v6mr12364834pgr.63.1530288846835; Fri, 29 Jun 2018 09:14:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530288846; cv=none; d=google.com; s=arc-20160816; b=vtKj0wx2VBkVvpBJbt75ZLSexYq1sgcFLul5+xSl1bduQhr/NNa7yW6HStfdYgpJHP 6/zZQ3dWM5OZU0cNtD5N//fvONASB90z/oJl1flP9MgtaS0Q2M20rdttuLu1sqDaj7Qn TD7/7YzWkAPvsFqp9w0L0cGnvStF7oQJN9nyxgAKqVKSBgSxZSuTmCQUMjJNSfs+vPLd XH02jC+U+SBYNfp4B2NzQ2SJqGR0wUcoe29tHuVXraohx2ttWtXgNXjtgbGpS6kmhkz8 +FtQbbJQV6t5OnPSQmUK2MtFi+ME+iFo1sNbJ0e710mUhCiXClc6zP3hSOpokXuTU539 7WWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=pm8pMmSvPR0bMAJEgAosoyN1NvjoeiWRfduiOQBmCh8=; b=rX9k43hm7s85DsQX6nAbM63uM2fdRG7No2h3EamXIugwwL+61ar5klgY5YzXBixfNZ 3D65vXpuCgUJeavKXAdLiQZfMOHkG/rmXVdxsZheDXQ9bjw2GnPj9zygGn78K3fjxP3d iDy+EQfX8HI8eW9iGqE66G160kFmVYCS4FaB47vHqMTnwh0QEvmzX2KcPDWvEquQAczo yObrSaTyUraUFlrEi/wCW0bzNNhWc0++KeVwqrqs41XbVjzbDom5NdV/n45DcjMcNwpY qwfHpSqn403TBexlDgEENyZjoSJDIsoKGOLhhtp9MthMNdsJVYfrdciMdNiY09VBPP5J yGeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=KIc+2sRN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 66-v6si8041111pge.159.2018.06.29.09.13.52; Fri, 29 Jun 2018 09:14:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=KIc+2sRN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966311AbeF2N5B (ORCPT + 99 others); Fri, 29 Jun 2018 09:57:01 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:37486 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932529AbeF2N5A (ORCPT ); Fri, 29 Jun 2018 09:57:00 -0400 Received: by mail-it0-f67.google.com with SMTP id p17-v6so2985970itc.2 for ; Fri, 29 Jun 2018 06:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pm8pMmSvPR0bMAJEgAosoyN1NvjoeiWRfduiOQBmCh8=; b=KIc+2sRNRw9XIVlfZTB0GMJ05a2vfNcaSFd9SJE1FdJQYKtTY5i16UXfcMynSL413Y p4r6KWIZ9btsqXMfsJfoavjQKdFqFIKuaa5pX88bKDtx46eGrZW7RVrbO01uOdLqZKGZ Dyd6tA7NXMB99pRUdlAfIgtblWBz/L/6HffP8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pm8pMmSvPR0bMAJEgAosoyN1NvjoeiWRfduiOQBmCh8=; b=Z9qrZHGfRfKnldVVn94nRLEbdhvRWZi8lOjFCrW5lBzAQSG+XvEEAY6ZX5aNBwM1E4 9ixK4miCaB/xxDwGx3LYuslXBTNlvzfx0y0Br1FVM/jXlS7Hl9qR8UrkemY5qPVA8D0y SEy7S+HRfG+R3+hK98KpCemSnrLn1sYMQpmB8KKIYOGXKGVqrsIkZV+nDQ7AHS9+PixB xZ8aohbteBK8kAGBtukdGlwqlQNppHx2/0xqfcvtBidsQ0cz+qc4Nff1DLfqEaMkqQj3 kxltFJAtvOmRyUdpDYW6JQAu9RoGE3CmyKNDR8Rer784k3PTZ9S8+Usz15kcVuDvrkOd Hoaw== X-Gm-Message-State: APt69E233UEujesGYR8yGJwIsG1Ow3+3pgkCFwQWBMRb4Lo9Z2lB+VZE yMvWM0i++XJGqzlPRma8uVLKAotiXKIYbc8Ra8c= X-Received: by 2002:a24:3c09:: with SMTP id m9-v6mr1760452ita.113.1530280620024; Fri, 29 Jun 2018 06:57:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Fri, 29 Jun 2018 06:56:49 -0700 Message-ID: Subject: Re: [PATCH 2/2] drivers: core: Remove glue dirs from sysfs earlier To: Benjamin Herrenschmidt Cc: Greg Kroah-Hartman , "Eric W. Biederman" , Joel Stanley , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 28, 2018 at 7:22 PM Benjamin Herrenschmidt wrote: > > This fixes it by instead doing an explicit kobject_del() when > the glue dir is empty, by keeping track of the number of > child devices of the gluedir. Ugh. I was hoping that you'd just do the "only check duplicate names if actually in use" instead. This patch seems to make patch 1/2 pointless. No? Linus