Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 29 Jun 2018 19:38:32 +0300
From:   Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
To:     Michel =?iso-8859-1?Q?D=E4nzer?= <michel@daenzer.net>
Cc:     David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Use kvzalloc for allocating blob property memory
Message-ID: <20180629163832.GF5565@intel.com>
References: <20180629142710.2069-1-michel@daenzer.net>
 <20180629161205.GE5565@intel.com>
 <32deece3-b583-ca58-cd41-ba11846240c8@daenzer.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <32deece3-b583-ca58-cd41-ba11846240c8@daenzer.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 29, 2018 at 06:27:28PM +0200, Michel D?nzer wrote:
> On 2018-06-29 06:12 PM, Ville Syrj?l? wrote:
> > On Fri, Jun 29, 2018 at 04:27:10PM +0200, Michel D?nzer wrote:
> >> From: Michel D?nzer <michel.daenzer@amd.com>
> >>
> >> The property size may be controlled by userspace, can be large (I've
> >> seen failure with order 4, i.e. 16 pages / 64 KB) and doesn't need to be
> >> physically contiguous.
> > 
> > I wonder if we should enforce some kind of reasonable limit
> > on the blob size. Looks like we allow anything up to
> > ULONG_MAX currently. We can't tell at createblob time how
> > the thing is going to be used, so can't have any kind
> > of property specific limit unfortunately.
> 
> The failure I was seeing was for a gamma LUT, so a size limit alone
> cannot solve the issue.

Sure. I was just thinking that maybe we shouldn't allow someone to
allocate unlimited amounts of kernel memory via this interface. But
to do that effectively we'd also need to limit the total amount used
by all blobs.

-- 
Ville Syrj?l?
Intel