Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1529915117.git.zong@andestech.com> <4c4def99db5e0392238947dc878c5018cc7aca3e.1529915117.git.zong@andestech.com>
 <20180629071200.GC12956@infradead.org>
In-Reply-To: <20180629071200.GC12956@infradead.org>
From:   Zong Li <zongbox@gmail.com>
Date:   Sat, 30 Jun 2018 00:53:49 +0800
Message-ID: <CA+ZOyahLiGS-7DQO8ncJ_=w-Mkav33FBBOC9-K08XSyhPgjtGg@mail.gmail.com>
Subject: Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index
 and type for 32-bit
To:     hch@infradead.org
Cc:     Zong Li <zong@andestech.com>, Palmer Dabbelt <palmer@sifive.com>,
        linux-riscv@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        greentime@andestech.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Christoph Hellwig <hch@infradead.org> =E6=96=BC 2018=E5=B9=B46=E6=9C=8829=
=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=883:12=E5=AF=AB=E9=81=93=EF=BC=
=9A
>
> On Mon, Jun 25, 2018 at 04:49:39PM +0800, Zong Li wrote:
> > Use generic marco to get the index and type of symbol.
>
> Why do we even need this in a uapi header?  Shouldn't ELF_RISCV_R_SYM
> and ELF_RISCV_R_TYPE move to module.c?  In that case we could just
> use CONFIG_64BIT.

Make sense. I even think the all definitions can be move to include/asm/elf=
.h.
How do you think about that?