Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 29 Jun 2018 20:37:28 +0200
Message-ID: <s5hvaa1iglz.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Nicholas Mc Guire" <hofrat@osadl.org>
Cc:     "Johannes Berg" <johannes@sipsolutions.net>,
        <alsa-devel@alsa-project.org>, <linuxppc-dev@lists.ozlabs.org>,
        "Jaroslav Kysela" <perex@perex.cz>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: snd-aoa: add of_node_put() in error path
In-Reply-To: <1530292062-31567-1-git-send-email-hofrat@osadl.org>
References: <1530292062-31567-1-git-send-email-hofrat@osadl.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 29 Jun 2018 19:07:42 +0200,
Nicholas Mc Guire wrote:
> 
>  Both calls to of_find_node_by_name() and of_get_next_child() return a
> node pointer with refcount incremented thus it must be explicidly
> decremented here after the last usage. As we are assured to have a
> refcounted  np  either from the initial
> of_find_node_by_name(NULL, name); or from the of_get_next_child(gpio, np)
> in the while loop if we reached the error code path below, an
> x of_node_put(np) is needed.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Fixes: commit f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
> ---
> 
> Problem located by an experimental coccinelle script
> 
> Patch was compiletested with: ppc64_defconfig (implies CONFIG_SND_AOA=m)
> 
> Patch is against 4.18-rc2 (localversion-next is next-20180629)

Applied, thanks.


Takashi