Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1217300imm; Fri, 29 Jun 2018 13:39:51 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKVio41HeRXnkCPWY/f5LFAPOEx+qL2ex5J8bG/TSqNzB/BNDuT/X2dlN37yQgcfaPbILFO X-Received: by 2002:a17:902:aa98:: with SMTP id d24-v6mr16571855plr.185.1530304791545; Fri, 29 Jun 2018 13:39:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530304791; cv=none; d=google.com; s=arc-20160816; b=ubc4Op/0jGuCdudenr2HlAh9gQoeWJCNy+H6vEs0xXxLL4BolcZ6xTZFU2yIn4KNJa kM87n748a1Z1so2OrqkHQtKTsD+rsZLnA4XFIxrxq4z4zl55wILLYfrhMhCe78DsEzc0 tpR7vqFbEgVAy69U90XxEyS4RMFP3qqSqBcfpcRwR9vzkJ7LOAEoqbGszthsZkfOD8WJ LWzvLzOPmPop/f7Eo4MlkayouVE4onS/lAOcDTgVn0WvcYuLIqbstxFFoIF+0hSmlx7/ NNJGzZd7/k9zPdEMNMFvp/zxniAIu4swaLkcXafdvz9J5W9hVpk4rOiOj15aLNcSwDu7 /hTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=D9BluGmC3QDyQ72zz5xsYtX8ttzaa54autRrxRZ2oh4=; b=rL7u52kRDes4rMlCwmX8Q43di9P7oVWIe1NAHvB7PqBCmIYp7jrsxoov85LqKXCFY2 sxUpFVYswnZsV18nfjdMZufiTfOrI36KRVedVjlKgrzt48vKfGLY7yWgEpp6uX8eSXV7 y5ArKONbvB+NsMznhrYLL+Wm/qUJTCO+8bDS5+Cehqz8xE72bbDjM7zEICTTIOC083wp Bh0fSms47siEnQQbfG2cdVaBELL4vk5tX5qu30AW1RYcr0+5kYtZ/3IJRw4AEOCukRbt FLwktAZXf44v0nHDiZ8VpAEUF6+B8yXBcLoMR0cKdiaRdNG+c8RJibHn+LD967pAA0Bo 3Hvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MhsWNS0B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g63-v6si8956638pgc.151.2018.06.29.13.39.34; Fri, 29 Jun 2018 13:39:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MhsWNS0B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935472AbeF2SK4 (ORCPT + 99 others); Fri, 29 Jun 2018 14:10:56 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:50427 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935178AbeF2SKz (ORCPT ); Fri, 29 Jun 2018 14:10:55 -0400 Received: by mail-wm0-f43.google.com with SMTP id v25-v6so2084333wmc.0 for ; Fri, 29 Jun 2018 11:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=D9BluGmC3QDyQ72zz5xsYtX8ttzaa54autRrxRZ2oh4=; b=MhsWNS0B2ShFO6nbz73xpNwpQWmW2qKv2G8T6c5FR0Y7IJbSTcK0LaErJA6Xs9HUUG ZXd4Bedwhfu5mPtwa1KgDvKaJ+zkzaWRIM0AxzOJHxQRFYyQ4lwDebXyJq0oR3PZyJrV xGz6Gm+EVKe0DubKixvW7vK7ALNYy58F7q6XYyxa1mf/xmJfcF0b3Oi9vX/GthRC7gLJ AT1ipougmQDl0guTzL0yAVMYAROEwT8uJoUpJHn0JQTZV8PerCpkR/OFXR/GVLXqc2Qc eWqLeaMkBWIL6zIIGJ9af9lncuDqt4vRGOi1L3iX6xmjmdKFDcwy6SAtaNAZIGc1RmNG rBpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=D9BluGmC3QDyQ72zz5xsYtX8ttzaa54autRrxRZ2oh4=; b=WNvzw9BMNmN+KT3a+dGgiZmRUZ3CIasXgsW8iSx1eqH/QX4ldziM/3bFMrjw27gq/x 5JUEpt58MDS0NCiUKZhR3yu8TARSh3PheDG2/vBOpwglXK3tMBsGt9uCkGSGdZSx3+QN ljJp3ycn3AG4DsUoco/hN7g0QX8e49WnGXRhqLGKKlbSjk4cum0WGetLyShbfIidfGv2 zwdiM8fUp+ltx0NCGQQ2PmJ7YBlm7qJArHRKOVDCBud0F2ahaVSuG8+9hTpwDySp0/wL q51bQ9eFZ2VD4s3ktna0hZC7cKemn0s4zIITk0vqbyn9UwWxkXhtOTVCYaI1WOrwLRQ5 I5/A== X-Gm-Message-State: APt69E0vH+Lu0G5JEekIta3nAoRuozsUUSgbWk1YBJ3o8c5jq7wQwn2K QqzMD1LF0XPf6UE2JN7aeYc= X-Received: by 2002:a1c:e3d5:: with SMTP id a204-v6mr2442651wmh.20.1530295854455; Fri, 29 Jun 2018 11:10:54 -0700 (PDT) Received: from localhost.localdomain (host81-152-164-58.range81-152.btcentralplus.com. [81.152.164.58]) by smtp.gmail.com with ESMTPSA id t10-v6sm11071491wrq.74.2018.06.29.11.10.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Jun 2018 11:10:53 -0700 (PDT) From: John Whitmore To: devel@driverdev.osuosl.org Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, pombredanne@nexb.com, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org Subject: staging: rtl8192u: RFC - harmonisation of rtl819x_HT.h ? Date: Fri, 29 Jun 2018 19:10:04 +0100 Message-Id: <20180629181007.18071-1-johnfwhitmore@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch set includes two fairly trivial patches but the third patch is possibly controversial. There are two files called rtl819x_HT.h $ find -name rtl819x_HT.h -print ./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h ./drivers/staging/rtl8192e/rtl819x_HT.h The two files are very similar but the rtl8192u file includes more, and I think unused, definitions definitions. My, possibly flawed, thinking is that it might be easier to maintain a single file if the two could be merged into a single include file. As a first step towards this my third patch comments out unused definitions, from ./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h At this point I have compiled all c files under ./drivers/staging/rtl8192u and all still compile. I may well have missed something, but I assume that no source file outside that sub tree should be including header files from that subtree.