Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 29 Jun 2018 14:23:07 -0600
From:   Keith Busch <keith.busch@linux.intel.com>
To:     Keith Busch <keith.busch@intel.com>
Cc:     Johannes Thumshirn <jthumshirn@suse.de>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 2/4] nvme: use hw qid in trace events
Message-ID: <20180629202307.GA13865@localhost.localdomain>
References: <20180629200000.16171-1-keith.busch@intel.com>
 <20180629200000.16171-3-keith.busch@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180629200000.16171-3-keith.busch@intel.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 29, 2018 at 01:59:58PM -0600, Keith Busch wrote:
> +	    TP_printk("qid=%d, cmdid=%u, nsid=%u, flags=0x%x, meta=0x%llx, cmd=(%s %s)",
> +		      __entry->qid, __entry->nsid, __entry->cid, 

Ugh, the nsid and cid are swapped here, and carried through to the end
of the series. Will need to send a v4.