Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system
 configuration"
To:     Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc:     Vineet Gupta <vgupta@synopsys.com>,
        lkml <linux-kernel@vger.kernel.org>
References: <1530279747-25320-1-git-send-email-rppt@linux.vnet.ibm.com>
 <4c84ef6c-fa71-8b74-826a-d81dac8c71e7@infradead.org>
 <20180629192838.GE4799@rapoport-lnx>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <e18f80e1-fc59-9487-95eb-7cb6cda976c5@infradead.org>
Date:   Fri, 29 Jun 2018 13:28:59 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180629192838.GE4799@rapoport-lnx>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 06/29/2018 12:28 PM, Mike Rapoport wrote:
> Hi Randy, 
> 
> On Fri, Jun 29, 2018 at 09:34:55AM -0700, Randy Dunlap wrote:
>> On 06/29/2018 06:42 AM, Mike Rapoport wrote:
>>> Otherwise mm configuration options show up in the top level menu.
>>>
>>> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
>>
>> Hi Mike,
>>
>> In which config tool does this matter?
>>
>> For xconfig, it seems to me that this patch hides the MM menu, whereas
>> before this patch, the MM menu is easy to find (although it could
>> use some kind of heading).
> 
> With xconfig the menu gets into the top right pane when you click on "ARC
> architecture configuration", similar to what one gets on x86 with
> "Processor type and features" or "Kernel features" on ARM.
> 
> With menuconfig it looks a bit more prominent, note that mm options are
> between "ARC Architecture Configuration" and "Networking support":

I know.  I ran all 4 of menuconfig, nconfig, xconfig, and gconfig.

I would prefer to see Memory Management options have its own top-level
menu, but that's a different patch.  Then menuconfig would look like this:


│ │        *** Compiler: arc-linux-gcc (GCC) 8.1.0 ***                  │ │  
  │ │        General setup  --->                                          │ │  
  │ │    [*] Enable loadable module support  --->                         │ │  
  │ │    [*] Enable the block layer  --->                                 │ │  
  │ │        ARC Architecture Configuration  --->                         │ │  
  │ │        Memory Management options  --->                              │ │  
  │ │    (11) Maximum zone order                                          │ │  
  │ │    [*] Networking support  --->                                     │ │  
  │ │        Device Drivers  --->                                         │ │  
  │ │        Bus Support  ---> 


but that "Maximum zone order" needs to be moved or taken care of somehow.


[snip]

> 
> 
> 
>>>  	default "12" if ARC_HUGEPAGE_16M
>>>  	default "11"
>>>  
>>> +endmenu	 # "ARC Architecture Configuration"
>>> +
>>>  source "net/Kconfig"
>>>  source "drivers/Kconfig"


thanks,
-- 
~Randy