Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <2d0d235418958e8b60913b1e0d630b8c9213ea5b.camel@perches.com>
Subject: Re: [PATCH v7] drivers/staging: Gasket driver framework + Apex
 driver
From:   Joe Perches <joe@perches.com>
To:     Simon Que <sque@chromium.org>, linux-kernel@vger.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ben Chan <benchan@chromium.org>,
        Chun-Ta Lin <itspeter@chromium.org>,
        Zhongze Hu <frankhu@chromium.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Rob Springer <rspringer@google.com>,
        John Joseph <jnjoseph@google.com>
Date:   Fri, 29 Jun 2018 20:21:24 -0700
In-Reply-To: <20180630024938.107529-1-sque@chromium.org>
References: <20180630024938.107529-1-sque@chromium.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2018-06-29 at 22:49 -0400, Simon Que wrote:
> The Gasket (Google ASIC Software, Kernel Extensions, and Tools) kernel
> framework is a generic, flexible system that supports thin kernel
> drivers. Gasket kernel drivers are expected to handle opening and
> closing devices, mmap'ing BAR space as requested, a small selection of
> ioctls, and handling page table translation (covered below). Any other
> functions should be handled by userspace code.
[]
> [PATCH v4]
> - Deleted unused field "base" in struct gasket_coherent_buffer
> - Moved maintainer info to top-level MAINTAINERS file
> [PATCH v5]
> - Updated drivers/staging/Makefile change to apply to gregkh's staging
>   tree.

Why delete all the logging by adding if (false} tests
and then not mention it?