Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 30 Jun 2018 09:34:19 +0100
User-Agent: K-9 Mail for Android
In-Reply-To: <20180629181007.18071-4-johnfwhitmore@gmail.com>
References: <20180629181007.18071-1-johnfwhitmore@gmail.com> <20180629181007.18071-4-johnfwhitmore@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [PATCH 3/3] staging: rtl8192u: Prune the rtl819x_HT.h file of unused definitions.
To:     driverdev-devel@linuxdriverproject.org,
        John Whitmore <johnfwhitmore@gmail.com>,
        devel@driverdev.osuosl.org
CC:     kstewart@linuxfoundation.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, pombredanne@nexb.com,
        tglx@linutronix.de
From:   Justin Skists <justin.skists@juzza.co.uk>
Message-ID: <63457910-E837-458B-A80D-9D73DAF33FF5@juzza.co.uk>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 29 June 2018 19:10:07 BST, John Whitmore <johnfwhitmore@gmail.com> wrote:
>There are two files named "rtl819x_HT.h"
>
>$ find . -name rtl819x_HT.h -print
>./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
>./drivers/staging/rtl8192e/rtl819x_HT.h
>
>The two files are very similar but differ slightly. Unsed definitions
>have
>been removed from "drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h" as
>a first
>step towards possibly merging the two files into one.

Just delete the lines if they are unused. Don't worry about commenting them out. That way it is easier to visually diff the patches for review. (Plus, the previous code is never lost in the git tree, anyway)

:-)

Justin