Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 30 Jun 2018 18:44:06 +0900 (KST)
Message-Id: <20180630.184406.1626314416899588727.davem@davemloft.net>
To:     laoar.shao@gmail.com
Cc:     edumazet@google.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next] tcp: add new SNMP counter for drops when
 try to queue in rcv queue
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1530159776-29919-1-git-send-email-laoar.shao@gmail.com>
References: <1530159776-29919-1-git-send-email-laoar.shao@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Yafang Shao <laoar.shao@gmail.com>
Date: Thu, 28 Jun 2018 00:22:56 -0400

> When sk_rmem_alloc is larger than the receive buffer and we can't
> schedule more memory for it, the skb will be dropped.
> 
> In above situation, if this skb is put into the ofo queue,
> LINUX_MIB_TCPOFODROP is incremented to track it.
> 
> While if this skb is put into the receive queue, there's no record.
> So a new SNMP counter is introduced to track this behavior.
> 
> LINUX_MIB_TCPRCVQDROP:  Number of packets meant to be queued in rcv queue
> 			but dropped because socket rcvbuf limit hit.
> 
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>

Applied to net-next.