Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1530265876-18136-1-git-send-email-wanpengli@tencent.com>
 <1530265876-18136-3-git-send-email-wanpengli@tencent.com> <96bad133-077d-e27d-9f57-4df6399eb3b8@redhat.com>
In-Reply-To: <96bad133-077d-e27d-9f57-4df6399eb3b8@redhat.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Sat, 30 Jun 2018 18:04:47 +0800
Message-ID: <CANRm+CwjHX7Dr61aFHoSEftrj-nPMpyj9DGktg8wzXJ-zzNuFA@mail.gmail.com>
Subject: Re: [PATCH 2/2] KVM: X86: Implement PV send IPI support
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Radim Krcmar <rkrcmar@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 29 Jun 2018 at 18:45, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 29/06/2018 11:51, Wanpeng Li wrote:
> > From: Wanpeng Li <wanpengli@tencent.com>
> >
> > Using hypercall to send IPIs by one vmexit instead of one by one for
> > xAPIC/x2APIC physical mode and one vmexit per-cluster for x2APIC cluste=
r
> > mode.
> >
> > Even if enable qemu interrupt remapping and PV TLB Shootdown, I can sti=
ll
> > observe ~14% performance boost by ebizzy benchmark for 64 vCPUs VM, the
> > total msr-induced vmexits reduce ~70%.
> >
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
> > Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> > Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> > ---
> >  Documentation/virtual/kvm/cpuid.txt |  4 ++++
> >  arch/x86/kvm/cpuid.c                |  3 ++-
> >  arch/x86/kvm/x86.c                  | 25 +++++++++++++++++++++++++
> >  include/uapi/linux/kvm_para.h       |  1 +
> >  4 files changed, 32 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/virtual/kvm/cpuid.txt b/Documentation/virtua=
l/kvm/cpuid.txt
> > index ab022dc..d72359f 100644
> > --- a/Documentation/virtual/kvm/cpuid.txt
> > +++ b/Documentation/virtual/kvm/cpuid.txt
> > @@ -62,6 +62,10 @@ KVM_FEATURE_ASYNC_PF_VMEXIT        ||    10 || parav=
irtualized async PF VM exit
> >                                     ||       || can be enabled by setti=
ng bit 2
> >                                     ||       || when writing to msr 0x4=
b564d02
> >  ----------------------------------------------------------------------=
--------
> > +KVM_FEATURE_PV_SEND_IPI            ||    11 || guest checks this featu=
re bit
> > +                                   ||       || before enabling paravir=
tualized
> > +                                   ||       || send IPIs.
>
> It's not "enabling" but "using".  You also need to document the
> hypercall itself.

Will fix it in v2.

Regards,
Wanpeng Li