Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 30 Jun 2018 21:03:42 +0900 (KST)
Message-Id: <20180630.210342.804224843120744818.davem@davemloft.net>
To:     lipeng321@huawei.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, yisen.zhuang@huawei.com,
        salil.mehta@huawei.com
Subject: Re: [PATCH net-next 05/10] net: hns3: using modulo for cyclic
 counters in hclge_cmd_send
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1530271385-49668-6-git-send-email-lipeng321@huawei.com>
References: <1530271385-49668-1-git-send-email-lipeng321@huawei.com>
        <1530271385-49668-6-git-send-email-lipeng321@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Peng Li <lipeng321@huawei.com>
Date: Fri, 29 Jun 2018 19:23:00 +0800

> @@ -228,8 +228,7 @@ int hclge_cmd_send(struct hclge_hw *hw, struct hclge_desc *desc, int num)
>  		desc_to_use = &hw->cmq.csq.desc[hw->cmq.csq.next_to_use];
>  		*desc_to_use = desc[handle];
>  		(hw->cmq.csq.next_to_use)++;
> -		if (hw->cmq.csq.next_to_use == hw->cmq.csq.desc_num)
> -			hw->cmq.csq.next_to_use = 0;
> +		hw->cmq.csq.next_to_use %= hw->cmq.csq.desc_num;
>  		handle++;

I would advise against this.

The "%" modulus operation takes many cpu cycles, and the current code
is thus much faster.