Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp2535805imm; Sat, 30 Jun 2018 23:26:26 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfHLa6d4miAQ57RpNtVxOZmEUD7YkTv2OzZlnwqdkv8ZdNcWcb5+MZIwAKYQ2NQ7r3Yrfr8 X-Received: by 2002:a17:902:82c3:: with SMTP id u3-v6mr14411095plz.83.1530426386670; Sat, 30 Jun 2018 23:26:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530426386; cv=none; d=google.com; s=arc-20160816; b=oo+tXx4BbJPkkY1ZKL1F6LfrzqR7SqRT2+g5lXdFbr/gRVKm2i32lDZhrv2QV717Ql 78D2QRZvJOFIvYWk6zgcs0YmRfUcYrglQgkrFsHFAmG7VlLWalS2w+3d8aJeMcm4htgj tY+mSuzC2qFl1d8K3ewAfAaQQ/yibuhVMyNbb3vU8BPwzSFb0k4pP6fcVDYSzBz691AG 2rpfZYnQUKwkjZiRwuKuzqycv5BGXF/1IvH0re4wc7xoTguD6gwwnUwPWvKmGDMfAB4m KUzLLlypzRg527cFa4v/W3ypGTzEgeDyJepbA2UgX8yMDoG1fpJOgRvuLGsX5FBo3Q2+ wvOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=XHLlJYpadAYWSttabbfK1Mi8Ao0tg1Vvi2rQMNtagFM=; b=LsEb6EfmFslEUeOhTBEQwVJytVpF99K8+xId1sXdfhrTwx/LS1n1VHRcX1WrhL++F/ ++77WKsEG1fe/B5PvLIbza6XSSPKPqOytnF2KqwrRM4fTVxAp5foq2RI/HuD6SABis+m YGJVaxIJl+yQ9mrXOJQFKdwO9Z7RcHLsrCRL/dLFEBs7WC8o0hoff2wn8KArrvFOFyDm MO+kRguWQsK0IedM91zm3HVQIvvIM24U4tYYByM44zANFKkbws1vCOdU5bPzrkkDpIcf zjFIpkeYQU+UbLA0jJwocATmdx2L5eet3Z3unoEI+waPRizDx0zOHKcXFyf15ZlmQb6B yKAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1-v6si13802218plb.204.2018.06.30.23.25.58; Sat, 30 Jun 2018 23:26:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752031AbeGAGY6 (ORCPT + 99 others); Sun, 1 Jul 2018 02:24:58 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:53472 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbeGAGY4 (ORCPT ); Sun, 1 Jul 2018 02:24:56 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fZVmi-0006S2-Bg; Sun, 01 Jul 2018 14:24:32 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fZVmV-0007oa-HJ; Sun, 01 Jul 2018 14:24:19 +0800 Date: Sun, 1 Jul 2018 14:24:19 +0800 From: Herbert Xu To: Kees Cook Cc: "David S. Miller" , linux-crypto , "Gustavo A. R. Silva" , Arnd Bergmann , Eric Biggers , Alasdair Kergon , Giovanni Cabiddu , Lars Persson , Mike Snitzer , Rabin Vincent , Tim Chen , qat-linux@intel.com, dm-devel@redhat.com, LKML Subject: Re: [PATCH v2 11/11] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK Message-ID: <20180701062419.3opt7mnljf76hi4k@gondor.apana.org.au> References: <20180625211026.15819-1-keescook@chromium.org> <20180625211026.15819-12-keescook@chromium.org> <20180626092041.mxfg4lxcvxfivzc2@gondor.apana.org.au> <20180627143622.ntksjxsymo4yw6dz@gondor.apana.org.au> <20180627222749.xa5333caq5vaa7st@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 27, 2018 at 05:10:05PM -0700, Kees Cook wrote: > > In both cases here, what is "cipher"? i.e. what ciphers could lrw be > wrapping, and what ciphers could cts be wrapping, so that I can > examine the blocksizes, etc? A cipher is a simple cipher like aes that operates on a single block. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt