Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp2770013imm;
        Sun, 1 Jul 2018 05:20:43 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpdZaF5UPHub8ktY37t5ovJz59LmoSWPuaYMnvpoA+ipNqLfrYy//c4o4eAQCf2OKyYhiDAS
X-Received: by 2002:a62:b94:: with SMTP id 20-v6mr21077224pfl.234.1530447643288;
        Sun, 01 Jul 2018 05:20:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1530447643; cv=none;
        d=google.com; s=arc-20160816;
        b=Xf1gi+Vfip15DYjmt001IbUthI8AKgMOXV0oxWHiZD2GjIR5zI//h3fMUe+yImXrn5
         +moPjL+Fl6ErgCFqZzVtuN/n0fH7xF5CNjYhI+sNm0RzeepEq0AUmlSZdcIeIojpvp+J
         dAdbK2nPIN4hv5Iaxbayn4Yc2xul+CN24ZFbGeA6axMNCeIIP7+KlayYMNXeG4NrAXPZ
         f8bQXsi0netek71prqsdM0FUgcOLqcl0bXfA4n94uWFZmMs/TJj1FWHUniCvTMxoha8G
         5HHhBHiEGK+HMNRZJEHg156RX3DBV8OO4CGRZmxqzFvFYAEkCk6j7Rf0SLEIiXEwsmcb
         yz6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:arc-authentication-results;
        bh=dziT5xWdv0z7/pdjTPFRDkzopf4VWbtKSaWRIIBamig=;
        b=cL9lqklFO9wRtjSfpA9Lj4slB0cilpADB8TSbkSNluV4HKvrkuDcoNQXXNQbK5Bp3i
         u5pLbxLfL/ueVITNAvcZ7/zlHVMUcY2p6VcKXxLYN2KRdgmaBx6MtfFnsEuw7+eRiegR
         ndRjF1YxnvgMtofcWgl9jzXdbD/aXGPfs2RZCx5s9UqV/zsb4XmymycZTvje64Qh2ra9
         8D/cAC6aCbVRH503dsWB6Y/A0mCt9Xc9b0Hjkp2BY8x16CIgs1ACM272eIDvja86riHh
         ugQKKkxPkJ5mArG1pLryJYzlIRAhcw0N5R+h0+3nrZCw/OsdnuLk4vGlH96YI1V5xruK
         AL+w==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id s23-v6si2505019pga.563.2018.07.01.05.20.28;
        Sun, 01 Jul 2018 05:20:43 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752217AbeGAMTv (ORCPT <rfc822;deadfox.tw@gmail.com>
        + 99 others); Sun, 1 Jul 2018 08:19:51 -0400
Received: from charlotte.tuxdriver.com ([70.61.120.58]:37628 "EHLO
        smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752057AbeGAMTu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 1 Jul 2018 08:19:50 -0400
Received: from cpe-2606-a000-111b-40b7-215-ff-fecc-4872.dyn6.twc.com ([2606:a000:111b:40b7:215:ff:fecc:4872] helo=localhost)
        by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256)
        (Exim 4.63)
        (envelope-from <nhorman@tuxdriver.com>)
        id 1fZbKF-0006a4-5k; Sun, 01 Jul 2018 08:19:38 -0400
Date:   Sun, 1 Jul 2018 08:18:58 -0400
From:   Neil Horman <nhorman@tuxdriver.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     kbuild@01.org, kbuild-all@01.org, linux-rdma@vger.kernel.org,
        Adit Ranadive <aditr@vmware.com>,
        VMware PV-Drivers <pv-drivers@vmware.com>,
        Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed
Message-ID: <20180701121857.GA20336@neilslaptop.think-freely.org>
References: <20180628135938.19625-1-nhorman@tuxdriver.com>
 <20180630191507.dtzpvvvicmphnzsz@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180630191507.dtzpvvvicmphnzsz@mwanda>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jun 30, 2018 at 10:15:07PM +0300, Dan Carpenter wrote:
> Hi Neil,
> 
> I love your patch! Perhaps something to improve:
> 
> url:    https://github.com/0day-ci/linux/commits/Neil-Horman/vmw_pvrdma-Release-netdev-when-vmxnet3-module-is-removed/20180628-232414
> 
> smatch warnings:
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c:987 pvrdma_pci_probe() warn: variable dereferenced before check 'dev->netdev' (see line 985)
> 
Appreciate the smatch check, but this was caught by visual review and fixed in V2 already.

Best
Neil