Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp2988490imm; Sun, 1 Jul 2018 09:47:55 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIk2Xc/KMzQC9ObVOG7xzJba2zECC5YtVdVXgYgJ/+fSSSQz+XTHMFNOFYapF0I5JOoVhzy X-Received: by 2002:a17:902:2c83:: with SMTP id n3-v6mr22387339plb.211.1530463675883; Sun, 01 Jul 2018 09:47:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530463675; cv=none; d=google.com; s=arc-20160816; b=KAc+rnGoOrtojkJp8xptXCVe7lTvJNEoQZZV4UUD/EDH+JWPwnQRwwzeR6S0cqIrgh PMSuHCfR3pP86kNdAYiKcrECeX+Sqqa3T4xIlMb0e8bN2Gfz/pQKB6vKIwzDI5F/xhtx jaoQ2rEPLYdNdjzsWyDtqV4MwgsDKHzzAqe5bHQLuYQBtKqisSTp47MjkMYCSULl0Qwl imGNT/mAisKNQPTYfstsOZSQU3DM4sCGSTAfdofhdzvUuyeWUpl1iy61ZtQZGpV3DAGo lU5oVASzuzT+sMVUBxHQGS6YFQZkyxCWINMaMm3Dk0u3fHVCq4Y01mshsRZWzw/JtycL Bu0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=pYi/LIyyBhZPb9ReQODYlSmEGe8megEtZ3eYRVuaxGM=; b=K1ToEj1cKcd/t5GIMel+7ijAIVaG2muSYR2Y4A9SYSNfoCzKCPagT5dgkQRWT/cLo0 +T3MzIpEiroUrooHC2LxbwOcsYXNJzf3tNplHLNgL97URKVvCZap+tpAKjDoAd7YPJTR 8jK7Pk2mF4Uelg0qJv/SIFHurOCiPsnthNLqBdQLtTLlKfm/egmtD+F33SGaFYg01Zc4 UTXFrg9zcw2n5WlQk4u0h1nnUabhk9sPnkYemtLo1fxPYN8c5t3jTorhFrnh8t/oPNLz ZE5lqYF0r2lc22qX5sgkg+j17W+rW5P0qLeW6qyV9wUR7JwvA+tAGFukdWRzLCRXy7m9 xm+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1-v6si13647450plo.241.2018.07.01.09.47.41; Sun, 01 Jul 2018 09:47:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966010AbeGAQqR (ORCPT + 99 others); Sun, 1 Jul 2018 12:46:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38344 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965956AbeGAQqK (ORCPT ); Sun, 1 Jul 2018 12:46:10 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 7A66DACC; Sun, 1 Jul 2018 16:46:09 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wolfram Sang , Geert Uytterhoeven , Linus Walleij , Wolfram Sang , stable@kernel.org Subject: [PATCH 4.17 207/220] i2c: gpio: initialize SCL to HIGH again Date: Sun, 1 Jul 2018 18:23:51 +0200 Message-Id: <20180701160916.813301887@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180701160908.272447118@linuxfoundation.org> References: <20180701160908.272447118@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wolfram Sang commit 12b731dd46d9ee646318e6e9dc587314a3908a46 upstream. It seems that during the conversion from gpio* to gpiod*, the initial state of SCL was wrongly switched to LOW. Fix it to be HIGH again. Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib") Signed-off-by: Wolfram Sang Tested-by: Geert Uytterhoeven Reviewed-by: Linus Walleij Signed-off-by: Wolfram Sang Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/busses/i2c-gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/i2c/busses/i2c-gpio.c +++ b/drivers/i2c/busses/i2c-gpio.c @@ -279,9 +279,9 @@ static int i2c_gpio_probe(struct platfor * required for an I2C bus. */ if (pdata->scl_is_open_drain) - gflags = GPIOD_OUT_LOW; + gflags = GPIOD_OUT_HIGH; else - gflags = GPIOD_OUT_LOW_OPEN_DRAIN; + gflags = GPIOD_OUT_HIGH_OPEN_DRAIN; priv->scl = i2c_gpio_get_desc(dev, "scl", 1, gflags); if (IS_ERR(priv->scl)) return PTR_ERR(priv->scl);