Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   NeilBrown <neil@brown.name>
To:     Linux Kernel Network Developers <netdev@vger.kernel.org>
To:     Rishabh Bhatnagar <rishabhb@codeaurora.org>, tgraf@suug.ch,
        linux-arm-msm@vger.kernel.org
Date:   Mon, 02 Jul 2018 11:32:22 +1000
Cc:     herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
        Rishabh Bhatnagar <rishabhb@codeaurora.org>
Subject: Re: [PATCH] lib: rhashtable: Correct self-assignment in rhashtable.c
In-Reply-To: <1530493906-19711-1-git-send-email-rishabhb@codeaurora.org>
References: <1530493906-19711-1-git-send-email-rishabhb@codeaurora.org>
Message-ID: <87muva2zix.fsf@notabene.neil.brown.name>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


(added netdev@vger.kernel.org)

On Sun, Jul 01 2018, Rishabh Bhatnagar wrote:

> In file lib/rhashtable.c line 777, skip variable is assigned to
> itself. The following error was observed:
>
> lib/rhashtable.c:777:41: warning: explicitly assigning value of
> variable of type 'int' to itself [-Wself-assign] error, forbidden
> warning: rhashtable.c:777
> This error was found when compiling with Clang 6.0. Change it to iter->sk=
ip.
>
> Change-Id: I5abd1ce5ba76737a73bd6eca94b07b1bd5267523
> Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>

Thanks for catching that!
Reviewed-by: NeilBrown <neilb@suse.com>

Thanks,
NeilBrown

> ---
>  lib/rhashtable.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/rhashtable.c b/lib/rhashtable.c
> index 9427b57..3109b2e 100644
> --- a/lib/rhashtable.c
> +++ b/lib/rhashtable.c
> @@ -774,7 +774,7 @@ int rhashtable_walk_start_check(struct rhashtable_ite=
r *iter)
>  				skip++;
>  				if (list =3D=3D iter->list) {
>  					iter->p =3D p;
> -					skip =3D skip;
> +					iter->skip =3D skip;
>  					goto found;
>  				}
>  			}
> --=20
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAls5gKYACgkQOeye3VZi
gbnaaA//X6cfLjJptNvnJ/mTpbJMfKFGXjlI1apdns2tBOaRN4/BCFzFMOrP7EAZ
JzmW6Qy3eSv6ef1bDxCOhah09XaLzAIW+k51eTswAivo1TWvBL5PRFflwrExxUF8
gThb9E/mfGV519BhdxofCJYULqMynbGS3oMBKPq/obBRdMRcLImghuBadoMy6SYk
mE31qgexatD8M1JZ4VCAKkSdG+5VMGZk7ZWiDle6898pZ2/3PWWBV1K5Xz4klvpO
F2WWKoQ5VbOVQV/MIiCwoiOW+NtkhDLxtWaVY0ti8qZ/6u/KtLIVxPVIZBqETu73
sH/VDJZI/fCS69EE8M1zfxN+APEvy2RrIn3OKtZYVFGlFeH0cVzHYFFnT5nYNn31
oIpS6CkksAEqzXuSEkN6Z2/QPGx2d9DDJnjA+uj5qWFiUkoyph/Wc7InHVhxCLpV
8gAf4+WPgVPtXEqhZdazGeDV+1Mn1d/YMbEalVM4ZAjJ5GdK80WHYT8wunyta3kC
4ucBTyVEfpCYZjJVts1+8P3c3aoDSFB3gj9GsjzRiXqpM/fBDHfAtL4DwpTLY6gT
f6IsaIpb6cvlb7PrDYdMkdVE0iv7ZdVkMtxDjnMXAjogXYKiNz45XXCeupvpMgpq
t+mJPJe5Mc6XKEp9hYMlyD2f1UQ1qPiAd5WkDGtc9HNwaXNwrvg=
=M+j9
-----END PGP SIGNATURE-----
--=-=-=--