Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3401619imm; Sun, 1 Jul 2018 20:54:00 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIK1M4aR0K8FcuHcrCKDkt2eMiAjO67u77i/GxgmzaTlAblSP5gqFUYCjUL/Yc1hxto4q9H X-Received: by 2002:a17:902:294a:: with SMTP id g68-v6mr24715512plb.58.1530503640131; Sun, 01 Jul 2018 20:54:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530503640; cv=none; d=google.com; s=arc-20160816; b=Sh6sWM7PYdqx2nzgGVzMotlE9QN/Ivq81l6zCtGjUEEOVX6Bg6abnu21I0ONlnMMHU 1Bk4Ka4GHYob2gbbnWJCXpge6at+4uOZGZ3cl2gZUKcZruNzshspm+Zxc42ByQUgQAHj UYBoxqJJsJh7pUYEIWpd4TGQPmlxd0le5fkqrWFtz2odDZTyzVR6onJCy8B5uhYifBOp 8qQ8530ZNIs7I4WL+vPo95iOeLuuNDoqP8jm3sAD0JlCfXvjlFBPlUp42F70GRZVn4ig mzMmMYuwXPb2YowoAqDgJ/Ng1FKxRgHWHObQYgzirib7y5c163LNcGijj8MvWHdlNEmK ib/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=WyT1LAYCUI16/JRcHyYNVtgiiP2gNxgIs0W5+TLKqXw=; b=qG5LDq21OorI5ZDzhJ2puQMVJ/L75vmhXDaDuYJJP6nwxkAR7V6Ob9B8M1FVX5XHdo dga27DdA0w9RVF4SFF616f5hea1DMb9/4sD7yKWMYsIEOt9ZUZVJZryZ48So2Oeq8llz 4VQImwOqPbddamiWXMF/6n447NwCItL6K0cJriSG+THbtRTK5VFM/67opeJNNqUweYiH 3lG5LU/eXXiY3y3fD/716NeFaZRoYm7pJflmA0UgNlu4mQEMjie77l5N3jTce3iesPuG vibCqLUF3WJ5Hip+n5X5TnY5s1chJpckO520CiG6kr7RJr8hTC9pREaDiYeeNGT7/Bwi 9EOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=UmHZ9B3U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o10-v6si13402485pgq.545.2018.07.01.20.53.45; Sun, 01 Jul 2018 20:54:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=UmHZ9B3U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbeGBDEF (ORCPT + 99 others); Sun, 1 Jul 2018 23:04:05 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:36376 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416AbeGBDED (ORCPT ); Sun, 1 Jul 2018 23:04:03 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w62343iP112107 for ; Mon, 2 Jul 2018 03:04:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : references : in-reply-to : from : date : message-id : subject : to : cc : content-type; s=corp-2017-10-26; bh=WyT1LAYCUI16/JRcHyYNVtgiiP2gNxgIs0W5+TLKqXw=; b=UmHZ9B3UJEePUGS46AyyuxLWwZ47iJ3HthBuBj90l9knsHQTKJvop77EUM+SpS4+vAIS /BvaU7rJLDg4yXQtv3l26halExNlSt7hTs03GM/E66lknWkjcMO0An1QYtSG+K+rBKED H87218z0hNihx+5iiyiFDC9/TA5HfUtbjfwUF01X8a546h7R00pB9tW/TOivlBD5TwSs NKQCUBAtOKDEytHCiuT6xIJNHw6wapx32xXMJZFzzCWTh7Vh9EgtCygt3KDSrqVwyQSk E37FXLN0yxuhj5FqWOkISlKMlFllLjbRAPcCvmCUz4rtNnAajwlj8R8ZLcEMvfulNKyx jQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2jx2gptkft-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 02 Jul 2018 03:04:02 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w62341nX002604 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 2 Jul 2018 03:04:02 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w62341ui007356 for ; Mon, 2 Jul 2018 03:04:01 GMT Received: from mail-oi0-f42.google.com (/209.85.218.42) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 01 Jul 2018 20:04:01 -0700 Received: by mail-oi0-f42.google.com with SMTP id m2-v6so5725947oim.12 for ; Sun, 01 Jul 2018 20:04:01 -0700 (PDT) X-Gm-Message-State: APt69E1z4rlib/5igy904SI6ZO8lT3yEqUT1WyIuNUq+98fresILRSZV 12uFnMSiFHOS5s48GKgz/VBGSYebVrUo8PXuKTw= X-Received: by 2002:aca:4784:: with SMTP id u126-v6mr14400452oia.229.1530500640719; Sun, 01 Jul 2018 20:04:00 -0700 (PDT) MIME-Version: 1.0 References: <20180702020417.21281-1-pasha.tatashin@oracle.com> <20180702020417.21281-2-pasha.tatashin@oracle.com> <20180702021121.GL3223@MiWiFi-R3L-srv> <20180702023130.GM3223@MiWiFi-R3L-srv> <20180702025343.GN3223@MiWiFi-R3L-srv> In-Reply-To: <20180702025343.GN3223@MiWiFi-R3L-srv> From: Pavel Tatashin Date: Sun, 1 Jul 2018 23:03:24 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] mm/sparse: add sparse_init_nid() To: bhe@redhat.com Cc: Steven Sistare , Daniel Jordan , LKML , Andrew Morton , kirill.shutemov@linux.intel.com, Michal Hocko , Linux Memory Management List , dan.j.williams@intel.com, jack@suse.cz, jglisse@redhat.com, Souptick Joarder , gregkh@linuxfoundation.org, Vlastimil Babka , Wei Yang , dave.hansen@intel.com, rientjes@google.com, mingo@kernel.org, osalvador@techadventures.net Content-Type: text/plain; charset="UTF-8" X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8941 signatures=668704 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=3 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=585 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807020035 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Ah, yes, I misunderstood it, sorry for that. > > Then I have only one concern, for vmemmap case, if one section doesn't > succeed to populate its memmap, do we need to skip all the remaining > sections in that node? Yes, in sparse_populate_node() we have the following: 294 for (pnum = pnum_begin; map_index < map_count; pnum++) { 295 if (!present_section_nr(pnum)) 296 continue; 297 if (!sparse_mem_map_populate(pnum, nid, NULL)) 298 break; So, on the first failure, we even stop trying to populate other sections. No more memory to do so. Pavel