Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3434917imm; Sun, 1 Jul 2018 21:53:53 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJTBew0UazSeBbuV1k0F8/6JfHQhrqi2WpAHgD/pN+TrAvCiFLffjghBSanl6gaPFujeNKb X-Received: by 2002:a65:638a:: with SMTP id h10-v6mr20687522pgv.269.1530507232962; Sun, 01 Jul 2018 21:53:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530507232; cv=none; d=google.com; s=arc-20160816; b=tdV+ob0WrmbEw0gUDvIFZ8AxUD/FbEWyv1oAGIxFJgAfaS6E7h2+HJeAhRO2AMjsrO kARYZ1uaB6HGBm56M1n2J42xieFflirQrARvq+9Q1UK9N4fXYue9TKXGcUWpShfU958N THrP2mc5VDbrIPY/WyKysgPyocL5zuUFze0Q7atEeCIPeGGilaw4JuRTd3KD5r3OHF65 hA+As15VgH8ICLFgMO9RrApzi4Pt5b+9aavkgoT8k6bja9aAJSZhEhNP4fWegpiFmACz QCxvrVrBhqmxBQityx8QyriAUeecPvuDJR6ApJRKGhXxX3k/O5SwNkvuE+i92A+FHEjF C8sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=uT5zId6ceyJtNTlbjNToP+UK//N4mY8EMKsL2RmwRlI=; b=vfSEq+uQ3TNaKpoK42irKGZMACNgYbO5FVtz4dEP6gpSkDCQxB2lvhzoCFrcV7TxYo RvBXDzTkE+lkQzG/yy7BSumeAa/ZDi/2gRkqQANX3s4af8yvZ1tFOVEHi5u3bLq41DoH keZ57w9WBeJhLDX9P+JHMD72KYYZnYJAzHaSFLF6s5FEIyUWK9ho/ryWC7lBbE6OcOok W3mbeYe8EGVLARKjdEqsuKe2MtSMx3UkZ/Twjr45Oi3k7hoE5bBkFEHpCPpeRqv3sLwz VZWSAZySGCbnQ18pEfV5oAzsv++yMpY6Ck6QMPDnjwW9vdneRS/ihAt7ZiPEfPtQSIF8 ST2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i126-v6si4089034pfc.296.2018.07.01.21.53.38; Sun, 01 Jul 2018 21:53:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753147AbeGBElc (ORCPT + 99 others); Mon, 2 Jul 2018 00:41:32 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:12058 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbeGBElZ (ORCPT ); Mon, 2 Jul 2018 00:41:25 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1, AES128-SHA) id ; Sun, 01 Jul 2018 21:41:22 -0700 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Sun, 01 Jul 2018 21:41:24 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Sun, 01 Jul 2018 21:41:24 -0700 Received: from [10.110.48.28] (10.110.48.28) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 2 Jul 2018 04:41:23 +0000 Subject: Re: [PATCH v2 4/6] mm/fs: add a sync_mode param for clear_page_dirty_for_io() To: kbuild test robot , CC: , Matthew Wilcox , Michal Hocko , Christopher Lameter , Jason Gunthorpe , Dan Williams , Jan Kara , , LKML , linux-rdma , References: <20180702005654.20369-5-jhubbard@nvidia.com> <201807020900.J6omiRbx%fengguang.wu@intel.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: Date: Sun, 1 Jul 2018 21:40:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201807020900.J6omiRbx%fengguang.wu@intel.com> X-Originating-IP: [10.110.48.28] X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2018 07:47 PM, kbuild test robot wrote: > Hi John, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.18-rc3] > [cannot apply to next-20180629] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/john-hubbard-gmail-com/mm-fs-gup-don-t-unmap-or-drop-filesystem-buffers/20180702-090125 > config: i386-randconfig-x075-201826 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > fs/f2fs/dir.c: In function 'f2fs_delete_entry': >>> fs/f2fs/dir.c:734:33: error: 'WB_SYNC_ALL' undeclared (first use in this function); did you mean 'FS_SYNC_FL'? > clear_page_dirty_for_io(page, WB_SYNC_ALL); > ^~~~~~~~~~~ > FS_SYNC_FL Fixed locally, via: diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 258f9dc117f4..ca20c1262582 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -16,6 +16,7 @@ #include "acl.h" #include "xattr.h" #include +#include static unsigned long dir_blocks(struct inode *inode) { thanks, -- John Hubbard NVIDIA