Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3524037imm; Mon, 2 Jul 2018 00:10:12 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKjByEPH4tnF1eaoUxUDuT4eBzhdAxYcAOgH9fK8n4KSPgM1vQI1NLwVXoknZQ4UrKosY+t X-Received: by 2002:a63:65c2:: with SMTP id z185-v6mr20416312pgb.276.1530515412431; Mon, 02 Jul 2018 00:10:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530515412; cv=none; d=google.com; s=arc-20160816; b=n/3k5JdANYNInWyKxoCBqdAoxBu4r+U2N+K3wNzHv3jq97SCwNJxD1irhVBugDIztJ Mkj7HsPG7Zr9Tpo99w5GEUO4yjr5EBvxFF3e+GJVhUchWTeO99+ISkncGjElxQcTwpow ofRFX1GecCmwY0ab1OngjtDSyQBCz4JNrzEg96yHoSY+HvznGnm6znB9/gYGWkQniA9+ NuCMlf/SBkJKznVFwbO//LA4Ql0tIPaVzUndnUI4xXF3nXXYKMOP/HADmLxi2gPrP4uQ ThJU9qJaOuQlmJBV7pr2B3ikXsa7nfxdXrIxje8ZyT+QTnYCl36tr4CbVLE+r8/NRYPg wtkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=DuyHrVKPmg2RDzJa5oAq28aqtlJnAo4n6JRCKUt/GoY=; b=Gp9duUmltzSyugvR7o1Ts/HtNbxXC7LpGFKKMms+uTms+WOnaXjwQnr7U+FC62lcHg NLAvg84XN+zgBV2Z4P1zGMmLQkv7FRIOLpZMRQaMoMiPwe2BAUmx5PU3+a8QhcA1VedU s7xWdhxfeCT3M/khsZ8jfo5GebzmB26h4Dow/0jgsF9fcniDMNvwJdkU8+Ow+jjp5Hs+ sjTpIbfEEx3QiuBH7sdQdcwB9Qfti7lyuNARJnowIQDJsL2kqLvURinGqf8XxYwehBNj V2p6jwPV0P5S730Rq9DYEO7q3q9u/Q9cKrxm8Q1gMfN31hMf6aJWbAZaTkAoDRp5rhO7 P6fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6-v6si15661157plb.409.2018.07.02.00.09.58; Mon, 02 Jul 2018 00:10:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932917AbeGBHGl (ORCPT + 99 others); Mon, 2 Jul 2018 03:06:41 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:39964 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbeGBHGh (ORCPT ); Mon, 2 Jul 2018 03:06:37 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fZsut-0002pl-9z; Mon, 02 Jul 2018 15:06:31 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fZsuq-0000S4-Qx; Mon, 02 Jul 2018 15:06:28 +0800 Date: Mon, 2 Jul 2018 15:06:28 +0800 From: Herbert Xu To: Rishabh Bhatnagar Cc: neilb@suse.com, tgraf@suug.ch, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib: rhashtable: Correct self-assignment in rhashtable.c Message-ID: <20180702070628.lhi63kcgcfwj64y4@gondor.apana.org.au> References: <1530493906-19711-1-git-send-email-rishabhb@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1530493906-19711-1-git-send-email-rishabhb@codeaurora.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 01, 2018 at 06:11:46PM -0700, Rishabh Bhatnagar wrote: > In file lib/rhashtable.c line 777, skip variable is assigned to > itself. The following error was observed: > > lib/rhashtable.c:777:41: warning: explicitly assigning value of > variable of type 'int' to itself [-Wself-assign] error, forbidden > warning: rhashtable.c:777 > This error was found when compiling with Clang 6.0. Change it to iter->skip. > > Change-Id: I5abd1ce5ba76737a73bd6eca94b07b1bd5267523 > Signed-off-by: Rishabh Bhatnagar Acked-by: Herbert Xu Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt