Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net-next 05/10] net: hns3: using modulo for cyclic
 counters in hclge_cmd_send
To:     David Miller <davem@davemloft.net>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>, <yisen.zhuang@huawei.com>,
        <salil.mehta@huawei.com>
References: <1530271385-49668-1-git-send-email-lipeng321@huawei.com>
 <1530271385-49668-6-git-send-email-lipeng321@huawei.com>
 <20180630.210342.804224843120744818.davem@davemloft.net>
From:   "lipeng (Y)" <lipeng321@huawei.com>
Message-ID: <5ef0b797-67ff-e84a-367d-bd3da96a13b3@huawei.com>
Date:   Mon, 2 Jul 2018 15:06:46 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180630.210342.804224843120744818.davem@davemloft.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2018/6/30 20:03, David Miller wrote:
> From: Peng Li <lipeng321@huawei.com>
> Date: Fri, 29 Jun 2018 19:23:00 +0800
>
>> @@ -228,8 +228,7 @@ int hclge_cmd_send(struct hclge_hw *hw, struct hclge_desc *desc, int num)
>>   		desc_to_use = &hw->cmq.csq.desc[hw->cmq.csq.next_to_use];
>>   		*desc_to_use = desc[handle];
>>   		(hw->cmq.csq.next_to_use)++;
>> -		if (hw->cmq.csq.next_to_use == hw->cmq.csq.desc_num)
>> -			hw->cmq.csq.next_to_use = 0;
>> +		hw->cmq.csq.next_to_use %= hw->cmq.csq.desc_num;
>>   		handle++;
> I would advise against this.
>
> The "%" modulus operation takes many cpu cycles, and the current code
> is thus much faster.
>
> .
Agree with you.

Thanks for your review, we  concentrate on  the code style and ignore the
performance in this patch, It is not good.

I will remove this patch from the patchset.

>