Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <0a812d02-d85d-f685-6e7f-f4dfe22f9629@gmx.com>
References: <20180625053058.25206-1-cgxu519@gmx.com> <0a812d02-d85d-f685-6e7f-f4dfe22f9629@gmx.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 2 Jul 2018 09:14:03 +0200
Message-ID: <CAJZ5v0gpBShiR5oQawfrLh_fMBK7EqfPbT4TBeNDjn6Kkou_7A@mail.gmail.com>
Subject: Re: [PATCH] kernel/power: cast PAGE_SIZE to int when comparing with
 error code
To:     cgxu519 <cgxu519@gmx.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Pavel Machek <pavel@ucw.cz>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 2, 2018 at 3:10 AM, cgxu519 <cgxu519@gmx.com> wrote:
> Hi Rafael,
>
> Could you have a look at this simple patch?

I've done that already and I'm going to apply it.

Thanks,
Rafael


> On 06/25/2018 01:30 PM, Chengguang Xu wrote:
>>
>> If PAGE_SIZE is unsigned type then negative error code will be
>> larger than PAGE_SIZE.
>>
>> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
>> ---
>>   kernel/power/swap.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
>> index c2bcf97d24c8..d7f6c1a288d3 100644
>> --- a/kernel/power/swap.c
>> +++ b/kernel/power/swap.c
>> @@ -923,7 +923,7 @@ int swsusp_write(unsigned int flags)
>>         }
>>         memset(&snapshot, 0, sizeof(struct snapshot_handle));
>>         error = snapshot_read_next(&snapshot);
>> -       if (error < PAGE_SIZE) {
>> +       if (error < (int)PAGE_SIZE) {
>>                 if (error >= 0)
>>                         error = -EFAULT;
>>   @@ -1483,7 +1483,7 @@ int swsusp_read(unsigned int *flags_p)
>>         memset(&snapshot, 0, sizeof(struct snapshot_handle));
>>         error = snapshot_write_next(&snapshot);
>> -       if (error < PAGE_SIZE)
>> +       if (error < (int)PAGE_SIZE)
>>                 return error < 0 ? error : -EFAULT;
>>         header = (struct swsusp_info *)data_of(snapshot);
>>         error = get_swap_reader(&handle, flags_p);
>
>