Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; 
  s=zapps768; d=zoho.com; 
  h=date:from:reply-to:to:cc:message-id:in-reply-to:references:subject:mime-version:content-type:user-agent; 
  b=pdG7D4setLlbcpm+n1LjzUs57WjM5f/OURfWcK/eLCVHzUkfPNrWX3MCIFbHIyJPyvT28zTlXpa0
    wznWYXHkMpMI8Jh5aCUNL8hQjBpzDA7dsuGpiKZulYyz1ZmU6dA1  
Date:   Mon, 02 Jul 2018 14:23:42 +0800
From:   Huaisheng Ye <yehs2007@zoho.com>
Reply-To: yehs2007@zoho.com
To:     "\"Al Viro\"" <viro@ZenIV.linux.org.uk>
Cc:     <dan.j.williams@intel.com>, <dave.jiang@intel.com>,
        <willy@infradead.org>, <ross.zwisler@linux.intel.com>,
        <vishal.l.verma@intel.com>, <jack@suse.com>, <chengnt@lenovo.com>,
        <linux-nvdimm@lists.01.org>, <linux-kernel@vger.kernel.org>,
        <linux-ext4@vger.kernel.org>, "\"Huaisheng Ye\"" <yehs1@lenovo.com>
Message-ID: <16459a9432e.10c419704327.5268154349116077352@zoho.com>
In-Reply-To: <20180701192600.GT30522@ZenIV.linux.org.uk>
References: <20180701061848.7036-1-yehs2007@zoho.com>
 <20180701061848.7036-2-yehs2007@zoho.com> <20180701192600.GT30522@ZenIV.linux.org.uk>
Subject: Re: [PATCH 2/3] fs/ext2/inode: Fix a type cast error for fsdax
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
User-Agent: Zoho Mail
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

 ---- On Mon, 02 Jul 2018 03:26:00 +0800 Al Viro <viro@ZenIV.linux.org.uk> wrote ---- 
 > On Sun, Jul 01, 2018 at 02:18:47PM +0800, Huaisheng Ye wrote: 
 > > From: Huaisheng Ye <yehs1@lenovo.com> 
 > >  
 > > The type of offset within struct iomap is loff_t, which represents 
 > > file offset of mapping. 
 > >  
 > > In ext2_iomap_begin, iomap->offset shall be given a type cast as 
 > > loff_t instead of u64. 
 >  
 > Why is it an error?  loff_t is uniformly typedefed to long long. 
 > In which case the second variant is different from the first one 
 > *and* does not step into nasal demon territory?

Sorry for my inaccuracy.
The type of iomap->offset is loff_t, is it better to cast first_block
to loff_t, then do the left shift operation?
 
 >  
 > > -    iomap->offset = (u64)first_block << blkbits; 
 > > +    iomap->offset = (loff_t)first_block << blkbits; 
 > 

---
Cheers,
Huaisheng