Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3562244imm; Mon, 2 Jul 2018 01:06:07 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe9ISVtWNdIVbyhXx5+Ok8ty53xTeBbDwlz/I7uNRroPfs27bzfoWo8kkfYZm6Ty0CsccGs X-Received: by 2002:a65:6203:: with SMTP id d3-v6mr12064367pgv.420.1530518767545; Mon, 02 Jul 2018 01:06:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530518767; cv=none; d=google.com; s=arc-20160816; b=I/Dqc+jgyrSqzZpkHuCaP+T08wPYgtiI99laoTqtZ6x5eAITj4gu/k+pZdNKR+UQzk CgggQmEMg1iHrlgZRK+mZqJ6OxYCULkP8pXCwGox11gAWQQJlh+zi7uXW6zVWsMNyRvC dJ8QDzB48lVwcUbMpHoLbLMEkqDqtgVvKD0I2Cfv+e7JH2Zx9qBNQeGqXusDF8NMcxPD J4GV3qJhbl+mo95AY6NUnv0f2mG59Xp68TgqmQ+yS9yVsf4b4jNButaOMFXO1/AJ62JE EdWvtGvnKbT2Z8gDSctMbCG2qCbedsN/AMBR736p4hLLoZhD5kAuocGT7GVZs8k6zvNI ZAkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=bWO5OWF2z1ULQ20wBhUAxr3wpdsd7HNxWdF43WvhvWo=; b=KDGIWt7fGXHJ0XTg4TLbmYE2Hvl3P6k9R7umc0E6SXrdwejl5z9g7+VdjTDVyoonG/ DPSTbHIssrFjG5EyyD+G7OcFwPwSSuGV7PjQFbf2APZDpuRH+TcNDyZKVsil/zwIa9uS DBBLSpKZKSNg0d5xQzA7w9k9t+QNnzC59pikQlWTaWhL+rKVGvov7RHmKskh+ibRGCMP kHGT7eEwEN6kxXB5heV7GRwha73ks/3AZyNr1/yUaJLlQJLy9L4FKDSQ/8h5459NoEjw eK/HItvBehb4IXKa740kotuYHrcUJRzuHI8IElGKxiMNNYcgO3Jwd61AB6Rw5k6fRFoi wykg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6-v6si14233382pgg.366.2018.07.02.01.05.52; Mon, 02 Jul 2018 01:06:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933423AbeGBIFL (ORCPT + 99 others); Mon, 2 Jul 2018 04:05:11 -0400 Received: from muru.com ([72.249.23.125]:49434 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752607AbeGBIFI (ORCPT ); Mon, 2 Jul 2018 04:05:08 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5B9EA8047; Mon, 2 Jul 2018 08:08:03 +0000 (UTC) Date: Mon, 2 Jul 2018 01:05:05 -0700 From: Tony Lindgren To: Maciej Purski Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Carlos Hernandez , Marek Szyprowski Subject: Re: [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev Message-ID: <20180702080505.GN112168@atomide.com> References: <20180615112916.GK112168@atomide.com> <1529330913-11152-1-git-send-email-m.purski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1529330913-11152-1-git-send-email-m.purski@samsung.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Maciej Purski [180618 14:11]: > If the regulator is not coupled, balance_voltage() should preserve > its desired max uV, instead of setting the exact value like in > coupled regulators case. > > Remove debugs, which are not necessary for now. Sorry for the delay in testing. I gave your series with this one a quick boot test on beagleboard-x15 and now the output is different. So instead of just hanging it seems to be stuck in some eternal loop see below. Regards, Tony 8< ------- * Loading modules ...[ 14.490595] omap-mailbox 48840000.mailbox: omap mailbox rev 0x400 [ 14.498515] omap-mailbox 48842000.mailbox: omap mailbox rev 0x400 [ 14.535853] omap_wdt: OMAP Watchdog Timer Rev 0x01: initial timeout 60 sec [ 14.937029] lib80211: common routines for IEEE802.11 drivers [ 15.350565] cfg80211: Loading compiled-in X.509 certificates for regulatory database [ 15.448875] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7' [ 15.460831] platform regulatory.0: Direct firmware load for regulatory.db failed with error -2 [ 15.469916] cfg80211: failed to load regulatory.db [ 16.092151] cpu cpu0: regulator_set_voltage: 3387 [ 16.097313] smps12: regulator_set_voltage_unlocked: 3040 [ 16.109880] smps12: optimal uV: 1154000 current uV: 970000, max uV: 1250000 [ 16.117085] smps12: regulator_set_voltage_rdev: 3110 [ 16.122696] smps12: _regulator_do_set_voltage: 2907 [ 16.130443] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.137824] smps12: regulator_set_voltage_rdev: 3110 [ 16.143334] smps12: _regulator_do_set_voltage: 2907 [ 16.149849] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.157174] smps12: regulator_set_voltage_rdev: 3110 [ 16.162683] smps12: _regulator_do_set_voltage: 2907 [ 16.169069] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.176391] smps12: regulator_set_voltage_rdev: 3110 [ 16.181932] smps12: _regulator_do_set_voltage: 2907 [ 16.188353] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.195614] smps12: regulator_set_voltage_rdev: 3110 [ 16.201199] smps12: _regulator_do_set_voltage: 2907 [ 16.207676] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.214931] smps12: regulator_set_voltage_rdev: 3110 [ 16.220614] smps12: _regulator_do_set_voltage: 2907 [ 16.227159] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.234379] smps12: regulator_set_voltage_rdev: 3110 [ 16.239961] smps12: _regulator_do_set_voltage: 2907 [ 16.246494] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.253746] smps12: regulator_set_voltage_rdev: 3110 [ 16.259890] smps12: _regulator_do_set_voltage: 2907 [ 16.267013] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.274114] smps12: regulator_set_voltage_rdev: 3110 [ 16.279565] smps12: _regulator_do_set_voltage: 2907 [ 16.288426] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.295562] smps12: regulator_set_voltage_rdev: 3110 [ 16.301580] smps12: _regulator_do_set_voltage: 2907 [ 16.308331] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.315655] smps12: regulator_set_voltage_rdev: 3110 [ 16.321328] smps12: _regulator_do_set_voltage: 2907 [ 16.327686] smps12: optimal uV: 1154000 current uV: 1160000, max uV: 1250000 [ 16.334945] smps12: regulator_set_voltage_rdev: 3110 [ 16.340662] smps12: _regulator_do_set_voltage: 2907