Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3591653imm; Mon, 2 Jul 2018 01:47:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc6mOyqE8luZ+97qotO3oMKjlJvGWe6BQ3LMd86VfbmXJKs3SrqsmMsotZ+wHdG8bqifyug X-Received: by 2002:a62:23d1:: with SMTP id q78-v6mr7797175pfj.179.1530521248138; Mon, 02 Jul 2018 01:47:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530521248; cv=none; d=google.com; s=arc-20160816; b=Rkc/kdPsAOaui4bPMl5iITDSx6hdsaM30s1Gs3eQgobAGfRpY1WmkwKtFngiIwib8V wfSERDVf+3DYXxH9bqglMn5NWldKVJxZVgYRYnW3enLHhAkrs9d604M9XRDS65+P9vmW 1HUpooUh4ncTQ0eWxB9jSLaonUZRep+7F56qm8gaeX1Km+Jnq/MJF2fBBQk/XjBP9PFI 7VrJAw4JucNqUzt1ZtyWq3PmnvJ/8lZ9/5sqigLKzKwKbTI7rtsCQ5PpzF8DVP5x7DUB tQPOenR2pqQPi2GAktpWTcjeeGhJuxNWOXE7bQNHFIgXBabtnJRk+i/g/jOQud20iSGK QY8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=dqQmLB0sJXKa3Z72KCi5YtOe3ZS5GiZ1uH1XKf1/Prk=; b=i6HYHEha0uPVQbdxSkfoPwTkVfWL0IwRiC+60EB43eaiKVLm5ydIR0rMm2Ky5KMi9a RWmXzX0KzQr/hAK/AXnXeGcOJQTVXRRzalljZaorce79rrKAMZ1Q/nAhmD7LotLgW/wH 369rf78AgBFtgQNZYsSFhnjvUAYudm4iZOGWvDut0X+QU1aJ1flVPCPy8pdDBOBvqYkw MOT0bkKrkvvFIrMXdYRdr7Ar6g8lilW/Yc+9gljU9/zgc28h/lKHxAIZnDlAlwdz1yrl 2o6BnvnP8pjaE7R7jgb8gYx5fHLArGKOl4Ulwn67TrYwM+vBAQ6gDUbVHxJAoumgVuY9 Wmrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n9-v6si15011117plk.310.2018.07.02.01.47.13; Mon, 02 Jul 2018 01:47:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933068AbeGBHHP (ORCPT + 99 others); Mon, 2 Jul 2018 03:07:15 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:39974 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933043AbeGBHHL (ORCPT ); Mon, 2 Jul 2018 03:07:11 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fZsvS-0002qs-CH; Mon, 02 Jul 2018 15:07:06 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fZsvR-0000SE-T0; Mon, 02 Jul 2018 15:07:05 +0800 Date: Mon, 2 Jul 2018 15:07:05 +0800 From: Herbert Xu To: Rishabh Bhatnagar Cc: neilb@suse.com, tgraf@suug.ch, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib: rhashtable: Correct self-assignment in rhashtable.c Message-ID: <20180702070705.yy2s4mrlcqajuh7k@gondor.apana.org.au> References: <1530493906-19711-1-git-send-email-rishabhb@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1530493906-19711-1-git-send-email-rishabhb@codeaurora.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 01, 2018 at 06:11:46PM -0700, Rishabh Bhatnagar wrote: > In file lib/rhashtable.c line 777, skip variable is assigned to > itself. The following error was observed: > > lib/rhashtable.c:777:41: warning: explicitly assigning value of > variable of type 'int' to itself [-Wself-assign] error, forbidden > warning: rhashtable.c:777 > This error was found when compiling with Clang 6.0. Change it to iter->skip. > > Change-Id: I5abd1ce5ba76737a73bd6eca94b07b1bd5267523 > Signed-off-by: Rishabh Bhatnagar I think you need to resend this patch via netdev@vger.kernel.org. Please add the acks when you repost. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt