Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3705261imm; Mon, 2 Jul 2018 04:13:32 -0700 (PDT) X-Google-Smtp-Source: AAOMgpftAxBD2f8ZvycKvXMyV+3m80n3ut7q89joDGeYVk8Rvak9O9psjiuLgiqL1RNOp8JYkteI X-Received: by 2002:a65:5b8e:: with SMTP id i14-v6mr17325704pgr.242.1530530012564; Mon, 02 Jul 2018 04:13:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530530012; cv=none; d=google.com; s=arc-20160816; b=aQtIYCko5B8x6QhP2LPUtl+DkcjQayWuQOZd2DWJuZD2rwK/Q+6gGMTjefu3aPVCXY AxZ393u2Sxl5IMyZOtfhEQdLlchG6MPwfG90cTM8uT1p6fCHI+uInyxwNSQugzH4Jg/D M6XdHyq5jdEjuxoJAghNIBYGDOCWZc8gOL6P2LR5f25DLduCIm6swVAMNIaVileGDUAB rqifw65MhO9WtwA60inyBdG4FK98xP0K1BUaGjtPzpiIlpPhWrx/xlm+lRUNve8Au7/t YDDEuLuvWQIEdZLCI6QCickg2siBH9fyWdp9QNXkOj70jF0cqOHj0ClKjQqOhi56Cd5Z WgsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :arc-authentication-results; bh=nV5KY7pSA9xWhVIrbUPHmYDbebMwkugX+oYoAFfppe8=; b=T0e88Pz84qDSpS+y73j4m2603yP0w34y6f+/eswmAGiIlSxvHR3iEeRp+fXS8YcEaJ 3IWahX+KUPt8B7qYSRnx07WRPCx13/8pjhPFrv1DyNuW8fWUwyqUSdq8zqHGcimAHrPT PzoSKTN0v5S0x2H2OKwlxkyVIGNPNauyNd4gIzVSD0RKB/cHyqFPI+B98eq47UUyonUk wMezNJG2TwzL34Ampc2o8l/NzVwomFrvecbfC1jgy4K9yX4dSYWwA0ZYif/ripLcXwKQ V+5yV45g8iX7AvI25UKbwrPvpC2iHJVXd0ajuMJbCK1UZO+BZqzoDEsw1WuZ/fndq036 ZVCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1-v6si16006245plj.474.2018.07.02.04.13.18; Mon, 02 Jul 2018 04:13:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933659AbeGBJ7n (ORCPT + 99 others); Mon, 2 Jul 2018 05:59:43 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:56350 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933467AbeGBJ7m (ORCPT ); Mon, 2 Jul 2018 05:59:42 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2DD8C18A; Mon, 2 Jul 2018 02:59:42 -0700 (PDT) Received: from [10.1.206.75] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 02CC13F5BA; Mon, 2 Jul 2018 02:59:39 -0700 (PDT) Subject: Re: [PATCH v3 05/20] kvm: arm/arm64: Fix stage2_flush_memslot for 4 level page table To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, cdall@kernel.org, eric.auger@redhat.com, julien.grall@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, punit.agrawal@arm.com, qemu-devel@nongnu.org References: <1530270944-11351-1-git-send-email-suzuki.poulose@arm.com> <1530270944-11351-6-git-send-email-suzuki.poulose@arm.com> From: Marc Zyngier Organization: ARM Ltd Message-ID: Date: Mon, 2 Jul 2018 10:59:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1530270944-11351-6-git-send-email-suzuki.poulose@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/06/18 12:15, Suzuki K Poulose wrote: > So far we have only supported 3 level page table with fixed IPA of 40bits. > Fix stage2_flush_memslot() to accommodate for 4 level tables. > > Cc: Marc Zyngier > Acked-by: Christoffer Dall > Signed-off-by: Suzuki K Poulose > --- > virt/kvm/arm/mmu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c > index 1d90d79..061e6b3 100644 > --- a/virt/kvm/arm/mmu.c > +++ b/virt/kvm/arm/mmu.c > @@ -379,7 +379,8 @@ static void stage2_flush_memslot(struct kvm *kvm, > pgd = kvm->arch.pgd + stage2_pgd_index(addr); > do { > next = stage2_pgd_addr_end(addr, end); > - stage2_flush_puds(kvm, pgd, addr, next); > + if (!stage2_pgd_none(*pgd)) > + stage2_flush_puds(kvm, pgd, addr, next); > } while (pgd++, addr = next, addr != end); > } > > Reviewed-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny...