Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3767485imm; Mon, 2 Jul 2018 05:20:20 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJBlLbvEShufcwSxNlYnXasDmW/7ZzQy74GD2Op+pl8L5VRgByxllmruOf4iwryPw8GAuLG X-Received: by 2002:a17:902:7c8b:: with SMTP id y11-v6mr24900203pll.222.1530534020429; Mon, 02 Jul 2018 05:20:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530534020; cv=none; d=google.com; s=arc-20160816; b=FeDD/Pn8KJ4lH5CdESdC/9IHZKzAa5zmk8gZGtys5X4KIxctaXmw3pnXoM3BTTtfxf aBzEtEn7+hHCcae3RcUDcTv4V9Jf3p29b3r3lGQeNPTIo8NAHSXhNW29lzGP9TacQfG3 mKybXSpDFyf7QbllkY4lFb+bIcuhsIxdW0tRwnKE/FzBzuTn5aD2CA3ko6YkZPRTLI+6 mnNVjD3q8UjSdYtIQGZkH8jvgdcmpdFxaLxbKOpGy3oSxbKXcvH9IMkkN13GHEUv8+7Z nO2MnyFfXWMqE2nJG88yZquK1H1xx4kqulT7gZHNYc9vDrMz4rMmpDymIRLwZGOXy5kK suPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=aQA14AgAeiOOiC4rYbFW53imUVd4Qn0YAM86rrZbrig=; b=Hdpbz76Tokz0xcplhBKxXlRmETVhlVD/ZM+5scMCXbY7dvz9E0Ze7WK+a1k7M7NRAs FqeuNXVz8b1/0MrYfYwIlcIETMOzkK5CcfWA4wKYvM7UczrzFRH/wq4HzKQ/WeH/LntA q1UeQAYxddAJ4cWHv7ZD+ILMm/ZzfUyNFQfJ4Z+kDes2YUYNY+PK917qO0I7BuxPiTDR o+UZtmui7DetYddQYLpMQnX7Flnnn3KCcRZ7YnLWhvChfSyu+s3/mnGmJYjU3cXrpBlO xooXJseBs6baIK+/9ph69IYqdha9Al+B0fwox/NjEtEjJZhi9n8uGkPs2oO4ZioP+a2A THxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=neHeWtkZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x5-v6si5944457pgc.210.2018.07.02.05.20.05; Mon, 02 Jul 2018 05:20:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=neHeWtkZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752613AbeGBMTL (ORCPT + 99 others); Mon, 2 Jul 2018 08:19:11 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:36234 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbeGBMTH (ORCPT ); Mon, 2 Jul 2018 08:19:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aQA14AgAeiOOiC4rYbFW53imUVd4Qn0YAM86rrZbrig=; b=neHeWtkZqt4JpJ4SxI6k0Ej3r BXqXhH/HzbArttG3zEPiAKFNttiPJMoOWBZEhABfhIE7haw1KtZhdPdFrnwTFV+eyGBe7OEdaJ1mg mMUMLMyRANNzbCBAp0moQbdUQCf3g/UfbaZ3BPPIxvdjlzUykiyVLUQx2WEIJz3nAOkW8fJc+5MfU Sk95X20/yrthNgGtyVsbZNCIb2/vEn9c8UcDILG8R5UjNf29fAi01FWXSyllVtAyN/YmPQjpyrLPE uOy/J0U1RQSMPEdIETOnnx47TRUen2tZjl9Z9uDh5KDtsPmFkLC14lt/63l8RE/nZg53fCeHg2SOT owRfFURFQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fZxnI-0006IX-Sq; Mon, 02 Jul 2018 12:19:01 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5C73D2029F1D9; Mon, 2 Jul 2018 14:18:59 +0200 (CEST) Date: Mon, 2 Jul 2018 14:18:59 +0200 From: Peter Zijlstra To: Fenghua Yu Cc: Thomas Gleixner , Dave Hansen , Ingo Molnar , H Peter Anvin , Ashok Raj , Alan Cox , Rafael Wysocki , Tony Luck , Ravi V Shankar , linux-kernel , x86 Subject: Re: [PATCH v2 2/4] x86/split_lock: Align x86_capability to unsigned long to avoid split locked access Message-ID: <20180702121859.GL2494@hirez.programming.kicks-ass.net> References: <1530282807-66555-1-git-send-email-fenghua.yu@intel.com> <1530282807-66555-3-git-send-email-fenghua.yu@intel.com> <20180629190346.GO18979@romley-ivt3.sc.intel.com> <20180629203844.GA68178@romley-ivt3.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180629203844.GA68178@romley-ivt3.sc.intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 29, 2018 at 01:38:44PM -0700, Fenghua Yu wrote: > include/linux/efi.h because set_bit() sets bits in efi.flags: > - unsigned long flags; > + unsigned long flags __aligned(unsigned long); > } efi; Help me out here; how is the above change not a complete no-op?