Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp5094imm; Mon, 2 Jul 2018 06:47:10 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKLvo8TIuaShI44wbRfHEwiGPZKZ5L+LFhDU7BAFlLl5JzPH9PD+QGVB1C6IzFFuhpjzoKn X-Received: by 2002:a63:6849:: with SMTP id d70-v6mr21270961pgc.7.1530539230209; Mon, 02 Jul 2018 06:47:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530539230; cv=none; d=google.com; s=arc-20160816; b=gCvCfhhOC30UBfJeMu74YStq1YVUVm3aeWqMPlwONW60jc1fGvbgxuRWBuYDJsEbIH s6LqtIVxmtEtDgwtOYaOXJ79E4eSuXS4tqy08V5XseiMls4OX7PAABvFzfb304lg7hZI ROliTy9cj1R6b9p9LOzKgQzLKDZ6IW5Mg0JU8PW0SXg40Ood6CTKyhxgl18m7RDqt1I2 DC4fA3WvtZmYThMGO9KJU4NZqJqb6OkndvYaWDk6E6pVkCLFjInwlS35rCQZcf7uz19f VAdlSSeuq8/3FyeRPoAS4XUF6yoDcrwatpNKoShgRrbsNMHsaEyLjLSVL8rl7cEZuaob XdQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=RBPLWCPZWmnWTMJFM42/nqLJcS0qQPCj9uGOkkEVNBw=; b=TYTUtujnt01Zq2NbGf/2XMrYYbLa7033cnhKwew4ekdSHxDe8a3SzV9j6Xmt6Dwobu zHSQVN0FEoS8qTDNZTnl2TVhihJhFwgBzNDkb9wTroBF/Tqp7mQtkOZsgU/SXzhJpMDJ tQTuck0J+E41zcBa/LImV/BNBoQnuib9yDlCXf69sx3Qkai1rwOD437bsmCyOcEZ3aaU ynqlk0UL44BzP7tB3shA3gWhVmXL4GNWMroBvoAI8nVXRbvNEry0cA+XiWbPClKXrSn0 bmo+c+pl3SXXHBSmNxdxXtymXK3Z5ClEuJQcS+H52Pyouh1X1T5ngIhge7EuoN1wOyBu porQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=rMrryhMq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b12-v6si13958284pgu.390.2018.07.02.06.46.52; Mon, 02 Jul 2018 06:47:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=rMrryhMq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbeGBNp1 (ORCPT + 99 others); Mon, 2 Jul 2018 09:45:27 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35772 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752110AbeGBNpP (ORCPT ); Mon, 2 Jul 2018 09:45:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RBPLWCPZWmnWTMJFM42/nqLJcS0qQPCj9uGOkkEVNBw=; b=rMrryhMqciz3/kxpIYOrqXxmY HkgZZ2IidmW+K13HMLN1A51QsjC7fVgzqViRalXn0cgXg0jhLvdPPoKn2HRSwUbF/TCmRc67QNrhm 1K9JhCG8g5aFV8Ps9+h861k0e5TLGX0J5nwpSI5j/RtbSUuB6UX7VDWkfc9bzNegmHb7ibFclbQYD IMvzaLjavGch+Cad8S+8bVkPtWxDQqERLgtqpsryblTK2xyWaTrnrGwr7Ek50ZnkALfmyMGhtEWNH cQHFgiI/K3Ff1XUYsBL7vj0pqvS0xLW6DLqh8lRj23nUp+jtSy3XEs52iUWb2+nyLLbq4IpesETzq t2cOzqCZg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fZytH-0004Cl-RU; Mon, 02 Jul 2018 13:29:15 +0000 Date: Mon, 2 Jul 2018 06:29:15 -0700 From: Christoph Hellwig To: Guo Ren Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, daniel.lezcano@linaro.org, jason@lakedaemon.net, arnd@arndb.de, c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, thomas.petazzoni@bootlin.com, wbx@uclibc-ng.org, green.hu@gmail.com Subject: Re: [PATCH V2 07/19] csky: MMU and page table management Message-ID: <20180702132915.GA6578@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This commit is missing an explanation. For the dma-mapping code please use the generic kernel/dma/noncoherent.c code instead of duplicating it.