Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp12187imm; Mon, 2 Jul 2018 06:54:38 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL3AgmJje00fh9Xj7hwRVNPv23vzExNtuuufbRijHYuW8mORxGJOWSrxERaqHZtRjYnvnZm X-Received: by 2002:a65:5ac9:: with SMTP id d9-v6mr21863398pgt.238.1530539678003; Mon, 02 Jul 2018 06:54:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530539677; cv=none; d=google.com; s=arc-20160816; b=wRA+SpVuuD5duFiS1IgtojqRtNkUGK6FBCdxVPoOpoM4WnEXuKsm2PzTg5UAag1xIR cr+Mo3TLOjFLJp6iS8eUnUZ3iIXHtf3ul96jqjRsCV/0gQbcnUwODcvbr6Ot39+6PL1e j45ygiD47VLbK9K9xK1QqjBqzUivGwAC6/Bu3IR8HFqfF8DrNbPD34I67s25QjWkoP6u Iomsl1kN3483lmd0ys4njjywoYS9ORGDibEJwVtqTBU3gB4Y9a5fVZ7sbAjaCPKqug7+ 83lLAgOxSSCpWlYvCCVYpY05W6JF/z9zY6gl/SH1Hd1ss9TVw3KwIXk6PTBQW+kY/PeC pbjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=LGWYP4V5D+CbYO2LKbP72Fb/RH+4HX2j7w/Unlw0BoQ=; b=d2Yv9gK4gSXvQG9TXkeNEZU4vSf7KEtL+LsaeTV3jq3eLSMGQppKTMz1mq0vWJ4CON beMSRWTI/zt+ZQlEyzFKcHihbpq9TcZ1/phwLqn+W1P0lE5u1xGaWEJPtK4SGGhW58tr kaxMOEsoy7kmN8Imi7bOtyffSl9SlcCG7oTp5F8u97ElCqeLhmSwy/6xOKBSTaRJHTF9 G4sQ533fIz3Z60/sgOTFfxKwKEpcXV1zZWgpMv25Xg8Avq8heZVs7DrWOlUwoaiJ7Wzx TummGIiPXmUhn9nWHybAiNaw8vv8cUuj593tfU4UOWw6ZFLMffF9i2f3PtPEjfZbNMGX sD4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si16052757plv.16.2018.07.02.06.54.23; Mon, 02 Jul 2018 06:54:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbeGBNxm (ORCPT + 99 others); Mon, 2 Jul 2018 09:53:42 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37224 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752445AbeGBNxj (ORCPT ); Mon, 2 Jul 2018 09:53:39 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w62DnmGC004815 for ; Mon, 2 Jul 2018 09:53:39 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2jyjaxya43-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 02 Jul 2018 09:53:38 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Jul 2018 14:53:36 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 2 Jul 2018 14:53:33 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w62DrWuD45154532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 2 Jul 2018 13:53:32 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4F1EA11C054; Mon, 2 Jul 2018 14:53:15 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55C9E11C05C; Mon, 2 Jul 2018 14:53:14 +0100 (BST) Received: from oc3836556865.ibm.com (unknown [9.152.224.39]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 2 Jul 2018 14:53:14 +0100 (BST) Subject: Re: [PATCH v6 07/21] s390: vfio-ap: base implementation of VFIO AP device driver To: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com, Tony Krowiak References: <1530306683-7270-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1530306683-7270-8-git-send-email-akrowiak@linux.vnet.ibm.com> From: Halil Pasic Date: Mon, 2 Jul 2018 15:53:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1530306683-7270-8-git-send-email-akrowiak@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18070213-4275-0000-0000-0000029445CD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18070213-4276-0000-0000-0000379BC008 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-02_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=831 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807020160 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29/2018 11:11 PM, Tony Krowiak wrote: > Introduces a new AP device driver. This device driver > is built on the VFIO mediated device framework. The framework > provides sysfs interfaces that facilitate passthrough > access by guests to devices installed on the linux host. > > The VFIO AP device driver will serve two purposes: > > 1. Provide the interfaces to reserve AP devices for exclusive > use by KVM guests. This is accomplished by unbinding the > devices to be reserved for guest usage from the default AP > device driver and binding them to the VFIO AP device driver. > > 2. Implements the functions, callbacks and sysfs attribute > interfaces required to create one or more VFIO mediated > devices each of which will be used to configure the AP > matrix for a guest and serve as a file descriptor > for facilitating communication between QEMU and the > VFIO AP device driver. > > When the VFIO AP device driver is initialized: > > * It registers with the AP bus for control of type 10 (CEX4 > and newer) AP queue devices. This limitation was imposed > due to: > > 1. A lack of access to older systems needed to test the > older AP device models; > > 2. A desire to keep the code as simple as possible; > > 3. Some older models are no longer supported by the kernel > and others are getting close to end of service. > > The probe and remove callbacks will be provided to support > the binding/unbinding of AP queue devices to/from the VFIO > AP device driver. > > * Creates a /sys/devices/vfio-ap/matrix device to hold > the APQNs of the AP devices bound to the VFIO > AP device driver and serves as the parent of the > mediated devices created for each guest. > > Signed-off-by: Tony Krowiak > --- > MAINTAINERS | 10 +++ > arch/s390/Kconfig | 11 +++ > drivers/s390/crypto/Makefile | 4 + > drivers/s390/crypto/vfio_ap_drv.c | 140 +++++++++++++++++++++++++++++++++ > drivers/s390/crypto/vfio_ap_private.h | 29 +++++++ > include/uapi/linux/vfio.h | 2 + > samples/bpf/bpf_load.c | 62 +++++++++++++++ You have probably touched the last one by accident. Regards, Halil