Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261203AbTILClM (ORCPT ); Thu, 11 Sep 2003 22:41:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261258AbTILClM (ORCPT ); Thu, 11 Sep 2003 22:41:12 -0400 Received: from note.orchestra.cse.unsw.EDU.AU ([129.94.242.24]:33964 "HELO note.orchestra.cse.unsw.EDU.AU") by vger.kernel.org with SMTP id S261203AbTILClK (ORCPT ); Thu, 11 Sep 2003 22:41:10 -0400 From: Neil Brown To: Adrian Bunk Date: Fri, 12 Sep 2003 12:40:39 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16225.12839.319206.649577@notabene.cse.unsw.edu.au> Cc: Kernel Mailing List Subject: Re: [2.6 patch] fix nfs4xdr.c compile warning In-Reply-To: message from Adrian Bunk on Tuesday September 9 References: <20030909113831.GN14800@fs.tum.de> X-Mailer: VM 7.17 under Emacs 21.3.2 X-face: [Gw_3E*Gng}4rRrKRYotwlE?.2|**#s9D CC fs/nfsd/nfs4xdr.o > fs/nfsd/nfs4xdr.c: In function `nfsd4_encode_open': > fs/nfsd/nfs4xdr.c:1773: warning: `return' with a value, in function returning void > ... > > <-- snip --> > > > The following patch tries to fix it: Thanks, though I've actually taken a different patch by Stephen Hemminger . > > BTW: > Shouldn't the return values of nfsd4_encode_open{,_confirm,_downgrade} > be checked in the switch in nfsd4_encode_operation? No. There is nothing meaningful in their return values. NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/