Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp253329imm; Mon, 2 Jul 2018 10:55:39 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJu5SxzI9tDG2CQ4ymYOrmOS43hOYnpIh6Bk7Lcunsqb2ta3cgbQrRNc92Z2xKbsjZRhZ8k X-Received: by 2002:a65:5686:: with SMTP id v6-v6mr22724430pgs.141.1530554139239; Mon, 02 Jul 2018 10:55:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530554139; cv=none; d=google.com; s=arc-20160816; b=vYemV7mVN4ZpgtdJUX18vQ2BBBpB5Hl5hykukTtb7wIEFjh+xG8wTB8buClHMa9COV cCpEyc62EQzrRaOLmHGxCdoHF+kB5V3A7xOP2stTXmwKW/GTkkYQ2i5AR1Kio3CJlmkc ugPflXLM+CXAs7Ck3S6bBtf5U1sSVgjOkKz0CAT4tuxozoVaJxpHrG/9M5VTjCQX2rwc fJT5qTV6tM+ASamns77froc8vHyRNuP9NHRUNQwiZizjU+gDdISnpXF2FF/u5aXyrGVq n1jta93pfXrgvzab6jmkaHGlYC/BYkLGzeUvlXpXfhTNZNGyNwmfK9KyDOzcKrDfQRX7 r0Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=ljFuLVXS3g7HboU9N3gwYtTe4kuCeA1nZKNUD6YBcGA=; b=EyNM8HNG0fR9/OUjsarv86X2WoSMaE+gR3JK8XE1/2tnuNyJkYcxoL4XHUSr+t66vd EHk5OX1lQFc3zIxjC8NFlE116F8RfMEIvEzEqA7rUwotb+dWFOFiKwqI1IPzGBauJVKQ oMux6Q5UpK+x/A9qE9EmMo0n6piRDK+3pIWAeenLOok+R+o+FQp3R72Jn9Md82cV17JD GYG9EqAGtfRaWSVkO81YAgeXcWW4G//uLskeFdcejV/cMlSD/boqim+aXNspj7rgxJPX UViz3Mc5kEhc12r7JtrrsjFqWLtbDY91Ym2nh4mFeeTL+H0mb61GuMIz7qULZh7jfsPz HSgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UMt6AYLV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j20-v6si16442900pll.211.2018.07.02.10.55.24; Mon, 02 Jul 2018 10:55:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UMt6AYLV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753230AbeGBRyD (ORCPT + 99 others); Mon, 2 Jul 2018 13:54:03 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35924 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752957AbeGBRyA (ORCPT ); Mon, 2 Jul 2018 13:54:00 -0400 Received: by mail-pg0-f66.google.com with SMTP id m19-v6so3932378pgv.3; Mon, 02 Jul 2018 10:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ljFuLVXS3g7HboU9N3gwYtTe4kuCeA1nZKNUD6YBcGA=; b=UMt6AYLVpgiB5oXoQUMVId/dpWQegFKlZPfOn4+MSZGJ/qPs/qW1Rn6E0/5J/fadVN Lo0ABcXX2YDe3c7InusYKfcWzXD418U0gr6jI0UKiYgk41TXJttM8xNFoZBgTF/He8Pq W/Qf41LePIjDzsRHIa0buIEmsXYwVfoqf2GdspGb+Kc8baXCtydgRP9lFI8syv4JZsrx Pp17nzrIxUx+FovSlr0AOASCIWksGJXofBR5eVZIgNDpuRXkwy0LL2gnZgutL0vrtOJC knXkgsNhwPRQVuhGmU3aSre6oyAjEo1Q5jvqtrrtKb5eFU5mXQhnCJo3bdCc9Husm0Wi c24g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ljFuLVXS3g7HboU9N3gwYtTe4kuCeA1nZKNUD6YBcGA=; b=oLBnhGY8p74jvDXzv69pZqFGJMgf3rGfKagYEi7UeWfqPNRw8j7/m4cFUn1Wc9rLAx M+yj4ujRcG+3WsMFIeigG3Ydy+nG1vl/iQ2p+VME80MZ2PRB6aDTARRa3T6k8Q+GDve/ kN73FwTuVF1C4svdf/JRMqnXn0sRVI1njjAfI7pLrroA7ufimsgN2J00u2tH37zGJE2N ch4DJdyJSy7IgyYje5qCTuzskXUyp7GkfkuNU1uXBW2MkuLQZFEtR5QW6PQBpii10rwN f/cJjI6il4r1pSfR3LzbhMnAG6SOt+0xAtVcJukIMUIw5YRmUa978lsIU6uKjLhoTc/X ZCdQ== X-Gm-Message-State: APt69E0v4zdvjhrIYzKVveVwto3t8JcrA51dctDF0s4ftzy7+5H5yM1H hv+lmwU7WrBN9Bw51pVnNxg= X-Received: by 2002:a63:8848:: with SMTP id l69-v6mr22120512pgd.377.1530554040209; Mon, 02 Jul 2018 10:54:00 -0700 (PDT) Received: from localhost.localdomain ([2601:644:8201:32e0:7256:81ff:febd:926d]) by smtp.gmail.com with ESMTPSA id z10-v6sm27304564pgo.58.2018.07.02.10.53.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jul 2018 10:53:59 -0700 (PDT) Date: Mon, 2 Jul 2018 10:53:57 -0700 From: Eduardo Valentin To: Amit Kucheria Cc: linux-kernel@vger.kernel.org, rnayak@codeaurora.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, smohanad@codeaurora.org, vivek.gautam@codeaurora.org, andy.gross@linaro.org, Kees Cook , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-soc@vger.kernel.org Subject: Re: [PATCH v4 0/6] thermal: tsens: Refactoring for TSENSv2 IP Message-ID: <20180702175357.GA28713@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 02, 2018 at 06:14:03PM +0530, Amit Kucheria wrote: > This series is a mixed bag: > - Some code moves to allow code sharing between various v2.x.y versions of > the TSENS IP, > - new qcom,tsens-v2.4.0 DT property for SDM845 and a generic qcom,tsens-v2 > property as a fallback compatible for all v2.x.y platforms, > - new platform support (sdm845) > - a cleanup patch and > - a DT change to have a common way to deal with the SROT and TM registers > despite slightly different features across the IP family and different > register offsets. > > Rob mentioned offline that we should expose the full version string of the > TSENS IP (x.y.z) and have a fallback compatible. I hope patch 4 does what > you were looking for. Applied patches 1, 3, and 4. Patch 5 needs a description. Patches 2 and 6 go via your arch tree. > > Regards, > Amit > > Amit Kucheria (6): > thermal: tsens: Get rid of unused fields in structure > dt: qcom: 8996: thermal: Move to DT initialisation > thermal: tsens: Rename tsens-8996 to tsens-v2 for reuse > thermal: tsens: Add support for SDM845 > thermal: tsens: Check if we have valid data before reading > arm64: dts: sdm845: Add tsens nodes > > .../devicetree/bindings/thermal/qcom-tsens.txt | 2 ++ > arch/arm64/boot/dts/qcom/msm8996.dtsi | 12 ++++++- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 +++++++++ > drivers/thermal/qcom/Makefile | 2 +- > drivers/thermal/qcom/{tsens-8996.c => tsens-v2.c} | 39 ++++++++++++---------- > drivers/thermal/qcom/tsens.c | 6 ++++ > drivers/thermal/qcom/tsens.h | 7 ++-- > 7 files changed, 62 insertions(+), 22 deletions(-) > rename drivers/thermal/qcom/{tsens-8996.c => tsens-v2.c} (66%) > > -- > 2.7.4 >