Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp256785imm; Mon, 2 Jul 2018 10:59:13 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIUwAbwOfI45mcNwHIGCMBX44qOnESSyyUN2eQtv9WCEI6NQ1ZdxdL/tPvDap9pRBaKxdsY X-Received: by 2002:a65:520c:: with SMTP id o12-v6mr22892750pgp.15.1530554353516; Mon, 02 Jul 2018 10:59:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530554353; cv=none; d=google.com; s=arc-20160816; b=pxrdZxtfP0NBtjemmgsWb1KBmLtEqebRUDr1jN1jDj2BmiMOkyNmqbmSQgUBfriD2L OoRorPExQC6sFE6qmb7eoFlXj9f3VUKWLFxtvUUvl15AsP+WsYBn2VZL9fWfX5Rk9mL7 0OYc1R+m6CIBzoGSFHWy1ttSEdzTifVHhnFzVEgji7pg55CEuNGaWVPnTqMTPjTDB3L6 XZ5VOD8LMHZMfPOL14Kf2miQS4A4orlcph/Wk7k9Jp1p11yE80FT9jB/NZ66vf9aYASY YiHwk0GoMFXcMphN7iwROcLYd+QPmWC+mqDONqkHxi1u3M+mIj8INGg375l/7m9jCxAs ZW3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject:arc-authentication-results; bh=xPgLo73tC50cAU30UvGxVOKD9bMyXObe0BaqGySd51k=; b=FLPFbsnqq02Au5xCvLdZsbd9bthb4tOtos1fdiph3dA7zkbarSWXoUCJmYn1lTp3Wi QV8Lt2CZzJ98JXM42nbHn1p6/ARBfvEo+8JCzX3XXtpM8yYsU/qkZiRMT+bnfH+gohpa neIbqxNWkWuzUZCzDFVA8H3d7vy17EdThO4hkG57GyC6Engjq7Lldg75cPU5CaF3sCeL Kfaz6zQFYbaibLRvM1MAzbiOjzCUAfkLg+3MhWaIRNY18ZyQdDcAddLtB9WctehjY83A DOLE2/bByUhtndE51yaf9PouCkCLJGYZWPl3ks7tk/9IgC67R9c5P3P4Q28XaVPPT2Df 3UmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n22-v6si16003461pff.370.2018.07.02.10.58.58; Mon, 02 Jul 2018 10:59:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753284AbeGBR6C (ORCPT + 99 others); Mon, 2 Jul 2018 13:58:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:49350 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753129AbeGBR6A (ORCPT ); Mon, 2 Jul 2018 13:58:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5B9ECAF43; Mon, 2 Jul 2018 17:57:58 +0000 (UTC) Subject: Re: [RFC net-next 08/15] net: lora: sx1276: Add debugfs To: Jiri Pirko Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jian-Hong Pan , Marcel Holtmann , "David S . Miller" , Matthias Brugger , Janus Piwek , =?UTF-8?Q?Michael_R=c3=b6der?= , Dollar Chen , Ken Yu References: <20180701110804.32415-1-afaerber@suse.de> <20180701110804.32415-9-afaerber@suse.de> <20180702162649.GC2737@nanopsycho.orion> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Autocrypt: addr=afaerber@suse.de; prefer-encrypt=mutual; keydata= xsFNBE6W6ZQBEAC/BIukDnkVenIkK9O14UucicBIVvRB5WSMHC23msS+R2h915mW7/vXfn+V 0nrr5ECmEg/5OjujKf0x/uhJYrsxcp45nDyYCk+RYoOJmGzzUFya1GvT/c04coZ8VmgFUWGE vCfhHJro85dZUL99IoLP21VXEVlCPyIngSstikeuf14SY17LPTN1aIpGQDI2Qt8HHY1zOVWv iz53aiFLFeIVhQlBmOABH2Ifr2M9loRC9yOyGcE2GhlzgyHGlQxEVGFn/QptX6iYbtaTBTU0 c72rpmbe1Nec6hWuzSwu2uE8lF+HYcYi+22ml1XBHNMBeAdSEbSfDbwc///8QKtckUzbDvME S8j4KuqQhwvYkSg7dV9rs53WmjO2Wd4eygkC3tBhPM5s38/6CVGl3ABiWJs3kB08asUNy8Wk juusU/nRJbXDzxu1d+hv0d+s5NOBy/5+7Pa6HeyBnh1tUmCs5/f1D/cJnuzzYwAmZTHFUsfQ ygGBRRKpAVu0VxCFNPSYKW0ULi5eZV6bcj+NAhtafGsWcv8WPFXgVE8s2YU38D1VtlBvCo5/ 0MPtQORqAQ/Itag1EHHtnfuK3MBtA0fNxQbb2jha+/oMAi5hKpmB/zAlFoRtYHwjFPFldHfv Iljpe1S0rDASaF9NsQPfUBEm7dA5UUkyvvi00HZ3e7/uyBGb0QARAQABzSJBbmRyZWFzIEbD pHJiZXIgPGFmYWVyYmVyQHN1c2UuZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgID AQIeAQIXgAUCTqGJnQIZAQAKCRD6LtEtPn4BPzetD/4rF6k/HF+9U9KqykfJaWdUHJvXpI85 Roab12rQbiIrL4hVEYKrYwPEKpCf+FthXpgOq+JdTGJ831DMlTx7Ed5/QJ9KAAQuhZlSNjSc +FNobJm7EbFv9jWFjQC0JcOl17Ji1ikgRcIRDCul1nQh9jCdfh1b848GerZmzteNdT9afRJm 7rrvMqXs1Y52/dTlfIW0ygMA2n5Vv3EwykXJOPF6fRimkErKO84sFMNg0eJV9mXs+Zyionfi g2sZJfVeKjkDqjxy7sDDBZZR68I9HWq5VJQrXqQkCZUvtr6TBLI+uiDLbGRUDNxA3wgjVdS2 v9bhjYceSOHpKU+h3H2S8ju9rjhOADT2F5lUQMTSpjlzglh8IatV5rXLGkXEyum4MzMo2sCE Cr+GD6i2M3pHCtaIVV3xV0nRGALa6DdF7jBWqM54KHaKsE883kFH2+6ARcPCPrnPm7LX98h2 4VpG984ysoq6fpzHHG/KCaYCEOe1bpr3Plmmp3sqj0utA6lwzJy0hj5dqug+lqmg7QKAnxl+ porgluoY56U0X0PIVBc0yO0dWqRxtylJa9kDX/TKwFYNVddMn2NQNjOJXzx2H9hf0We7rG7+ F/vgwALVVYbiTzvp2L0XATTv/oX4BHagAa/Qc3dIsBYJH+KVhBp+ZX4uguxk4xlc2hm75b1s cqeAD87BTQROlumUARAAzd7eu+tw/52FB7xQZWDv5aF+6CAkoz7AuY4s1fo0AQQDqjLOdpQF bifdH7B8SnsA4eo0syfs+1tZW6nn9hdy1GHEMbeuvdhNwkhEfYGDYpSue7oVxB4jajKvRHAP VcewKZIxvIiZ5aSp5n1Bd7B0c0C443DHiWE/0XWSpvbU7fTzTNvdz+2OZmGtqCn610gBqScv 1BOiP3OfLly8ghxcJsos23c0mkB/1iWlzh3UMFIGrzsK3sZJ/3uRaLYFimmqqPlSwFqx3b0M 1gFdHWKfOpvQ4wwP5P10xwvqNXLWC30wB1QmJGD/X8aAoVNnGsmEL7GcWF4cLoOSRidSoccz znShE+Ap+FVDD6MRyesNT4D67l792//B38CGJRdELtNacdwazaFgxH9O85Vnd70ZC7fIcwzG yg/4ZEf96DlAvrSOnu/kgklofEYdzpZmW+Fqas6cnk6ZaHa35uHuBPesdE13MVz5TeiHGQTW xP1jbgWQJGPvJZ+htERT8SZGBQRb1paoRd1KWQ1mlr3CQvXtfA/daq8p/wL48sXrKNwedrLV iZOeJOFwfpJgsFU4xLoO/8N0RNFsnelBgWgZE3ZEctEd4BsWFUw+czYCPYfqOcJ556QUGA9y DeDcxSitpYrNIvpk4C5CHbvskVLKPIUVXxTNl8hAGo1Ahm1VbNkYlocAEQEAAcLBXwQYAQIA CQUCTpbplAIbDAAKCRD6LtEtPn4BPzA6D/9TbSBOPM99SHPX9JiEQAw4ITCBF2oTWeZQ6RJg RKpB15lzyPfyFbNSceJp9dCiwDWe+pzKaX6KYOFZ5+YTS0Ph2eCR+uT2l6Mt6esAun8dvER/ xlPDW7p88dwGUcV8mHEukWdurSEDTj8V3K29vpgvIgRq2lHCn2wqRQBGpiJAt72Vg0HxUlwN GAJNvhpeW8Yb43Ek7lWExkUgOfNsDCTvDInF8JTFtEXMnUcPxC0d/GdAuvBilL9SlmzvoDIZ 5k2k456bkY3+3/ydDvKU5WIgThydyCEQUHlmE6RdA3C1ccIrIvKjVEwSH27Pzy5jKQ78qnhv dtLLAavOXyBJnOGlNDOpOyBXfv02x91RoRiyrSIM7dKmMEINKQlAMgB/UU/6B+mvzosbs5d3 4FPzBLuuRz9WYzXmnC460m2gaEVk1GjpidBWw0yY6kgnAM3KhwCFSecqUQCvwKFDGSXDDbCr w08b3GDk40UoCoUq9xrGfhlf05TUSFTg2NlSrK7+wAEsTUgs2ZYLpHyEeftoDDnKpM4ghs/O ceCeyZUP1zSgRSjgITQp691Uli5Nd1mIzaaM8RjOE/Rw67FwgblKR6HAhSy/LYw1HVOu+Ees RAEdbtRt37A8brlb/ENxbLd9SGC8/j20FQjit7oPNMkTJDs7Uo2eb7WxOt5pSTVVqZkv7Q== Organization: SUSE Linux GmbH Message-ID: Date: Mon, 2 Jul 2018 19:57:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180702162649.GC2737@nanopsycho.orion> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 02.07.2018 um 18:26 schrieb Jiri Pirko: > Sun, Jul 01, 2018 at 01:07:57PM CEST, afaerber@suse.de wrote: >> Allow some interactive inspection at runtime via debugfs. >> >> Signed-off-by: Andreas Färber [...] >> @@ -566,6 +691,10 @@ static int sx1276_probe(struct spi_device *spi) >> return ret; >> } >> >> + priv->debugfs = debugfs_create_dir(dev_name(&spi->dev), NULL); >> + debugfs_create_file("state", S_IRUGO, priv->debugfs, netdev, &sx1276_state_fops); >> + debugfs_create_file("frequency", S_IRUGO, priv->debugfs, netdev, &sx1276_freq_fops); > > Hmm. These look like useful information not only for debugging. I think > it would be worth to expose these via some standard uapi. Like generic > netlink, similar to nl80211 Which API to use for reading/writing such config data was question 4) in my cover letter. :) "frequency" was added first and helped me debug a calculation overflow. Netlink might indeed be an option here, haven't worked on it before, I'll look into nl80211. Thanks. "state" was just a partial dump of SPI registers, to monitor status changes after the initial probe or other callbacks with printks, while debugging GPIO interrupts iirc. So I'd think merging that to mainline would be unnecessary, but it could remain useful during development. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)