Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp397520imm; Mon, 2 Jul 2018 13:41:15 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdDu5//eEBsiH3JkOBytoKSg/LQxPdYTBZ48V6F0paBW5S2/e6Azw7/dhF0Rx2FuuQrMcfx X-Received: by 2002:a17:902:8c88:: with SMTP id t8-v6mr5638102plo.117.1530564075493; Mon, 02 Jul 2018 13:41:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530564075; cv=none; d=google.com; s=arc-20160816; b=WIk+YRjaxbA/vlQq8One4nAEoc4rvq7NZ356D2xKdHvy/rARd9++OxpuYtJfGJdiTQ cvs3QX1uR/krqblhiw2pBTS+KRe1HrDpm1TYqy8m0DQ1nm2VHZorPMDSwgWERdnBn2wA wRSY7vTU4eTqdYdYB+xStoG7gssY9bV3WdsSQDkVqIKUUcsMUe9lE7LDlSny5e4SYhne MHBZ+otMah1Cd9OQ70EbCkm5QUCrBIVyedab65RuciMMLaaeD7mluorynfuSspfNNKGc 42/WZbeeabOF0XLjUrR3lgiihLtcTeLgnqmqQwyvOh/0vISqwArdTHIioInaYcOh5yzz Gf2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=0K/K1KtGcAoEQgFZR7VgLuXoZxCTnmjFXtUHmqSqOn4=; b=rbOnTfAYvxvskgllr72/aQ+fvBsmWIzv6DIPZlXUmduRsh1JgUP6/UQnLp4sACF7j4 bMmYpcwAk6j3EVZDdV2smBGm+4PpOi7ukH9rUi16ShN4ZP8td5q7O66IOo9hnFhddUX/ uDLiON/oDY0lbrIt/q3hxWbkca36rtq6P6xKAFJ/rukw6Ym0D9aNvrYr8imwV0fx8oxf 7I63Gog9uHQKqcOkN41ussrx91/ctipJjd2KU7MrQznjO4cWz1v4LrQ5DiX/HPBIroVk o+dpJCmX40A028vQwXwa8FMqv+0NHmbUqd/bSKZeEP8SKlbUlkU/PIF7M5P24Iag8EdA 0oTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=C0zhLOUz; dkim=pass header.i=@codeaurora.org header.s=default header.b=C0zhLOUz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e16-v6si14328342pgv.561.2018.07.02.13.40.59; Mon, 02 Jul 2018 13:41:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=C0zhLOUz; dkim=pass header.i=@codeaurora.org header.s=default header.b=C0zhLOUz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752842AbeGBUkS (ORCPT + 99 others); Mon, 2 Jul 2018 16:40:18 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35630 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752197AbeGBUkP (ORCPT ); Mon, 2 Jul 2018 16:40:15 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E377A60B27; Mon, 2 Jul 2018 20:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1530564014; bh=qr2hkAkxy28+jjs5YpZlkpc3t0nMeQanF+TNnwnFI94=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=C0zhLOUzk7Ouswi/WtpbMv4f+xs5+4U09iaVjY+r7NhnrZku6X72tR93ETH5IiFQN JhZqj5lKH1NvP7ZpebGzDA5l/1vbCucWQh/TYp7RLkyn3kz5aDtyNySmSWZf/xMAWN JFPhluo1ms+my0qhIZ7N9kIQtsSbHzwIZUZzPUyY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.0.117] (cpe-174-109-247-98.nc.res.rr.com [174.109.247.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6DCD36031A; Mon, 2 Jul 2018 20:40:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1530564014; bh=qr2hkAkxy28+jjs5YpZlkpc3t0nMeQanF+TNnwnFI94=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=C0zhLOUzk7Ouswi/WtpbMv4f+xs5+4U09iaVjY+r7NhnrZku6X72tR93ETH5IiFQN JhZqj5lKH1NvP7ZpebGzDA5l/1vbCucWQh/TYp7RLkyn3kz5aDtyNySmSWZf/xMAWN JFPhluo1ms+my0qhIZ7N9kIQtsSbHzwIZUZzPUyY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6DCD36031A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V4 4/7] PCI: Unify try slot and bus reset API To: Andy Shevchenko Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm Mailing List , Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , Bjorn Helgaas , Alex Williamson , Alexey Kardashevskiy , Peter Xu , Zhenyu Wang , "open list:HFI1 DRIVER" , open list , "open list:VFIO DRIVER" References: <1530214274-21139-1-git-send-email-okaya@codeaurora.org> <1530214274-21139-4-git-send-email-okaya@codeaurora.org> From: Sinan Kaya Message-ID: <9674e845-765c-cc16-654e-21036038f2d5@codeaurora.org> Date: Mon, 2 Jul 2018 16:40:10 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/2018 5:43 PM, Andy Shevchenko wrote: >> +int pci_try_reset_bus(struct pci_dev *pdev) >> +{ >> + bool slot = false; >> + >> + if (!pci_probe_reset_slot(pdev->slot)) >> + slot = true; >> + >> + return slot ? __pci_try_reset_slot(pdev->slot) : >> + __pci_try_reset_bus(pdev->bus); > This can be as simple as > > return pci_probe_reset_slot(pdev->slot) ? > __pci_try_reset_bus(pdev->slot) : __pci_try_reset_slot(pdev->bus); > > done -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.