Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp404188imm; Mon, 2 Jul 2018 13:50:56 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeeavb96wCEDwsHjwjsVgRlzb3ztfYu7Ob/HbuA46WghI/xLc6+Qcprtc46t5FSpGbaF9yp X-Received: by 2002:a62:c0c4:: with SMTP id g65-v6mr21205431pfk.72.1530564656118; Mon, 02 Jul 2018 13:50:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530564656; cv=none; d=google.com; s=arc-20160816; b=Ahq+zdCCz7JrGB6EWX7elHuJgs5HbduTzjAk6aL+pbJyeTvYkw+zzBErhoN6dnw3Hn 5M10mHrfbjbvlM+VYtVrAqoB/c3beyjXA1kzGyP2VGFOiraBpmMZD6yy3UonTog6Mwb9 MHvnRay706imrSIrGrrYcv37kvbObZsTzMgpyCQVxoKXk/brraka8jBOZ14tVZ7yweGb UNU74Vt/7xaapk9UwQ4X7UHlf83uoRqPreWi9ZbV4sJEoioFK5XgLhkdtSs9clCSl8en YjlYdE0Q0qnyQHes2sjZhko+bqvYbJaH13PGdaSf0Bqmkc16HuRJ62B/fsSgwNUP033Q 0LSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=FzqBl1p4TuMo/DqEa+T0PgrEFpOZL/LY/MkYo4DmXVM=; b=vx0Wj/0V5Lge55BrImr+oZ4YVVsAG7HQXMuFOcqMHlrRCCTtljPoJo9wa0c2QSj0KX D8yZ9JJFbay2/gq2xXzua4gLDzjf4DWxCOKRiPORdOurmZ9BgcMA9rLPbRedTFF8vka9 UQuF2KAcFLYQeRHUtAb1A+NXfYn9W6EPUz7ShkXybb2TbppVBCVc4nHtCMifG8e/T5LV 1KzgHdvhb9QvlufmE31y5Blx/3mVvV1BpUmI/VicTPVJ1hOfDQpP9wOUsWMecT6FxR+X aiLe1Ok13NM/S6BiBjqwSnm8KJr2H0Lrg74AmTNErenI0mKKEJtZ6ywUSvRiX6yL9RVE 7y7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g4-v6si14013622pgs.340.2018.07.02.13.50.41; Mon, 02 Jul 2018 13:50:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbeGBUsu (ORCPT + 99 others); Mon, 2 Jul 2018 16:48:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34592 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537AbeGBUst (ORCPT ); Mon, 2 Jul 2018 16:48:49 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.92]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 9EC5FCFC; Mon, 2 Jul 2018 20:48:48 +0000 (UTC) Date: Mon, 2 Jul 2018 13:48:45 -0700 From: Andrew Morton To: Michal Hocko Cc: Yang Shi , willy@infradead.org, ldufour@linux.vnet.ibm.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, tglx@linutronix.de, hpa@zytor.com, linux-mm@kvack.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v3 PATCH 4/5] mm: mmap: zap pages with read mmap_sem for large mapping Message-Id: <20180702134845.c4f536dead5374b443e24270@linux-foundation.org> In-Reply-To: <20180702140502.GZ19043@dhcp22.suse.cz> References: <1530311985-31251-1-git-send-email-yang.shi@linux.alibaba.com> <1530311985-31251-5-git-send-email-yang.shi@linux.alibaba.com> <20180629183501.9e30c26135f11853245c56c7@linux-foundation.org> <084aeccb-2c54-2299-8bf0-29a10cc0186e@linux.alibaba.com> <20180629201547.5322cfc4b52d19a0443daec2@linux-foundation.org> <20180702140502.GZ19043@dhcp22.suse.cz> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Jul 2018 16:05:02 +0200 Michal Hocko wrote: > On Fri 29-06-18 20:15:47, Andrew Morton wrote: > [...] > > Would one of your earlier designs have addressed all usecases? I > > expect the dumb unmap-a-little-bit-at-a-time approach would have? > > It has been already pointed out that this will not work. I said "one of". There were others. > You simply > cannot drop the mmap_sem during unmap because another thread could > change the address space under your feet. So you need some form of > VM_DEAD and handle concurrent and conflicting address space operations. Unclear that this is a problem. If a thread does an unmap of a range of virtual address space, there's no guarantee that upon return some other thread has not already mapped new stuff into that address range. So what's changed?