Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp441228imm;
        Mon, 2 Jul 2018 14:36:47 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKLsAhsdtNFWcM0Vl7ha8GV1g70Gbi6PSJJAACyGYLizII0ah4Eem9PSg3NZOgPtNt/Y3rXQ
X-Received: by 2002:a17:902:714e:: with SMTP id u14-v6mr27706485plm.289.1530567407746;
        Mon, 02 Jul 2018 14:36:47 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1530567407; cv=none;
        d=google.com; s=arc-20160816;
        b=hj+MXjgthoWRVWJV0tSTxsXia9ZQ9HnjyPYXgdyn6JyyXMZ7mo6iMweULmSSsda31L
         uBAhRsb66mWlrxLum1h0CzQMGNd9F3S0mhtcyT24rOwhFMLoIYxFvuW8/W25o5ydyjqZ
         Cvs6W0f9CvNK2sg0adpqnzbMxm0YKfrAioUSqdaVwF0/MWzacRCuGN7U18VDQL3be68U
         785x0t3ZueoSoWKm9DXqkN0oRgFFKAgwsJ7D5DRqiKMAf2dN6680kpfF1nQBQYF/r0zH
         EUkSmHJAlq8PEDKwn2IML4zN7hHt+SFYJQ5aYugoQu6Bynuv3EKV5QpUboHn21JKvMEn
         EudA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=iHTqVDeoWk1Aq0K6TGca2MmBW4Ur7ahaR28IWWgZtVQ=;
        b=hcXvCIidcoy6dwe3LiE4YaW7b4zbpg6jl4DCD12gHlSln1SjQVwhGmJ2oek+Xjpw4e
         73qDxqTO7sg8B7In71hwZ/P38cz0eOAJ5AlCTo0q73tq8ry5+iQuwPc2o9yva0CQlbHE
         B3y6ktQH/1D4JfzM/yxrTBXeOQssDDv3b7si4VtgXCW0Cs71iUARu6KvM7agX+8kguNN
         jXo5uHIkNAE+9hltpFxCk/tDP4GgpMKnR93GdQLqFVykjU5dEsJv385lzWrf1taMWzdV
         Yv6KHKwBaAL83R+5NTNaL6jEqUqDa0Qq/ngzCxDrjdkefNG98afP7AS5uvKBsrUPubwu
         1bkw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id v65-v6si17182027pfb.324.2018.07.02.14.36.33;
        Mon, 02 Jul 2018 14:36:47 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753499AbeGBVfw (ORCPT <rfc822;utfcpqpk@gmail.com> + 99 others);
        Mon, 2 Jul 2018 17:35:52 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:2176 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753401AbeGBVfu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Jul 2018 17:35:50 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b3a9ab30000>; Mon, 02 Jul 2018 14:35:48 -0700
Received: from HQMAIL107.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Mon, 02 Jul 2018 14:35:49 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Mon, 02 Jul 2018 14:35:49 -0700
Received: from [10.110.48.28] (10.110.48.28) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 2 Jul
 2018 21:35:49 +0000
Subject: Re: [PATCH v2 1/6] mm: get_user_pages: consolidate error handling
To:     Jan Kara <jack@suse.cz>, <john.hubbard@gmail.com>
CC:     Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@kernel.org>,
        Christopher Lameter <cl@linux.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Dan Williams <dan.j.williams@intel.com>, <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
References: <20180702005654.20369-1-jhubbard@nvidia.com>
 <20180702005654.20369-2-jhubbard@nvidia.com>
 <20180702101725.esnjyo4zp3726i3n@quack2.suse.cz>
X-Nvconfidentiality: public
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <2bb69d70-33c4-3547-823d-4750df237d83@nvidia.com>
Date:   Mon, 2 Jul 2018 14:34:48 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180702101725.esnjyo4zp3726i3n@quack2.suse.cz>
X-Originating-IP: [10.110.48.28]
X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/02/2018 03:17 AM, Jan Kara wrote:
> On Sun 01-07-18 17:56:49, john.hubbard@gmail.com wrote:
>> From: John Hubbard <jhubbard@nvidia.com>
>>
>> An upcoming patch requires a way to operate on each page that
>> any of the get_user_pages_*() variants returns.
>>
>> In preparation for that, consolidate the error handling for
>> __get_user_pages(). This provides a single location (the "out:" label)
>> for operating on the collected set of pages that are about to be returned.
>>
>> As long every use of the "ret" variable is being edited, rename
>> "ret" --> "err", so that its name matches its true role.
>> This also gets rid of two shadowed variable declarations, as a
>> tiny beneficial a side effect.
>>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> 
> This looks nice! You can add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>
> 

Great, thanks for the review!

-- 
John Hubbard
NVIDIA